Skip to content

Merge branch 'main' into luan/fix-spells #5693

Merge branch 'main' into luan/fix-spells

Merge branch 'main' into luan/fix-spells #5693

GitHub Actions / luacheck succeeded Dec 11, 2023 in 0s

reviewdog [luacheck] report

reported by reviewdog 🐶

Findings (0)
Filtered Findings (76)

data/chatchannels/scripts/guild_leaders.lua|5 col 26| value of argument 'type' is overwritten on line 9 before use
data/events/scripts/creature.lua|7 col 8| value assigned to variable 'time' is unused
data/events/scripts/monster.lua|1 col 16| unused function 'calculateBonus'
data/events/scripts/monster.lua|12 col 16| unused function 'checkItemType'
data/events/scripts/player.lua|625 col 3| value assigned to variable 'item' is unused
data/libs/achievements_lib.lua|574 col 3| value assigned to field '480' is overwritten on line 583 before use
data/libs/achievements_lib.lua|575 col 3| value assigned to field '481' is overwritten on line 584 before use
data/libs/daily_reward/daily_reward.lua|41 col 8| value assigned to variable 'maxsoul' is unused
data/libs/daily_reward/daily_reward.lua|81 col 9| unused variable 'a'
data/libs/encounters_lib.lua|92 col 34| shadowing upvalue argument 'callable' on line 91
data/libs/encounters_lib.lua|173 col 27| shadowing upvalue loop variable 'position' on line 171
data/libs/encounters_lib.lua|177 col 32| shadowing upvalue loop variable 'position' on line 171
data/libs/encounters_lib.lua|189 col 12| shadowing definition of argument 'event' on line 177
data/libs/encounters_lib.lua|195 col 12| shadowing upvalue 'monster' on line 178
data/libs/functions/combat.lua|3 col 24| shadowing upvalue argument 'creature' on line 1
data/libs/functions/combat.lua|14 col 28| shadowing upvalue argument 'creature' on line 12
data/libs/functions/functions.lua|266 col 20| value assigned to variable 'spectator' is unused
data/libs/functions/functions.lua|281 col 20| value assigned to variable 'spectator' is unused
data/libs/functions/functions.lua|462 col 10| unused variable 'tile'
data/libs/functions/functions.lua|486 col 38| shadowing upvalue argument 'message' on line 441
data/libs/functions/functions.lua|650 col 11| shadowing definition of variable 'player' on line 596
data/libs/functions/functions.lua|691 col 20| value assigned to variable 'spectator' is unused
data/libs/functions/functions.lua|799 col 8| variable 'buffer' was previously defined as an argument on line 798
data/libs/functions/functions.lua|837 col 8| variable 'i' was previously defined as an argument on line 836
data/libs/functions/game.lua|51 col 16| value assigned to variable 'house' is unused
data/libs/functions/game.lua|63 col 17| value assigned to variable 'player' is unused
data/libs/functions/game.lua|79 col 17| value assigned to variable 'player' is unused
data/libs/functions/monstertype.lua|36 col 9| value assigned to variable 'count' is unused
data/libs/functions/player.lua|540 col 2| loop is executed at most once
data/libs/functions/position.lua|134 col 8| value assigned to variable 'result' is overwritten on line 137 before use
data/libs/functions/position.lua|150 col 8| value assigned to variable 'result' is overwritten on line 153 before use
data/libs/functions/string.lua|55 col 9| unused variable 'a'
data/libs/functions/tables.lua|43 col 8| unused variable 'newthing'
data/libs/hireling_lib.lua|59 col 16| unused function 'printTable'
data/libs/hireling_lib.lua|610 col 9| shadowing definition of variable 'outfit' on line 585
data/modules/lib/modules.lua|7 col 20| shadowing upvalue argument 'callable' on line 1
data/modules/lib/modules.lua|7 col 30| shadowing upvalue argument 'playerId' on line 1
data/modules/lib/modules.lua|8 col 9| shadowing upvalue 'player' on line 2
data/modules/scripts/daily_reward/daily_reward.lua|38 col 7| unused variable 'DAILY_REWARD_NONE'
data/modules/scripts/daily_reward/daily_reward.lua|39 col 7| unused variable 'DAILY_REWARD_HP_REGENERATION'
data/modules/scripts/daily_reward/daily_reward.lua|40 col 7| unused variable 'DAILY_REWARD_MP_REGENERATION'
data/modules/scripts/daily_reward/daily_reward.lua|41 col 7| unused variable 'DAILY_REWARD_STAMINA_REGENERATION'
data/modules/scripts/daily_reward/daily_reward.lua|42 col 7| unused variable 'DAILY_REWARD_DOUBLE_HP_REGENERATION'
data/modules/scripts/daily_reward/daily_reward.lua|43 col 7| unused variable 'DAILY_REWARD_DOUBLE_MP_REGENERATION'
data/modules/scripts/daily_reward/daily_reward.lua|44 col 7| unused variable 'DAILY_REWARD_SOUL_REGENERATION'
data/modules/scripts/daily_reward/daily_reward.lua|59 col 7| unused variable 'DAILY_REWARD_SYSTEM_TYPE_OTHER'
data/modules/scripts/daily_reward/daily_reward.lua|603 col 40| empty if branch
data/modules/scripts/gamestore/init.lua|241 col 51| empty if branch
data/modules/scripts/gamestore/init.lua|339 col 9| value assigned to variable 'category' is unused
data/modules/scripts/gamestore/init.lua|357 col 9| value assigned to variable 'category' is unused
data/modules/scripts/gamestore/init.lua|568 col 8| value assigned to variable 'GameStoreCategories' is unused
data/modules/scripts/gamestore/init.lua|568 col 29| value assigned to variable 'GameStoreCount' is unused
data/modules/scripts/gamestore/init.lua|616 col 8| unused variable 'playerId'
data/modules/scripts/gamestore/init.lua|1401 col 7| shadowing definition of loop variable 'k' on line 1400
data/modules/scripts/gamestore/init.lua|1451 col 7| shadowing definition of loop variable 'k' on line 1450
data/modules/scripts/gamestore/init.lua|1478 col 7| shadowing definition of loop variable 'i' on line 1476
data/modules/scripts/gamestore/init.lua|1725 col 3| value assigned to variable 'message' is unused
data/modules/scripts/gamestore/init.lua|1727 col 10| shadowing upvalue argument 'player' on line 1695
data/modules/scripts/gamestore/init.lua|1974 col 8| value assigned to variable 'op' is unused
data/modules/scripts/gamestore/init.lua|2201 col 22| shadowing upvalue argument 'playerId' on line 2198
data/modules/scripts/gamestore/init.lua|2202 col 9| unused variable 'offer'
data/modules/scripts/gamestore/init.lua|2202 col 9| shadowing upvalue argument 'offer' on line 2198
data/modules/scripts/gamestore/init.lua|2203 col 9| shadowing upvalue argument 'newHirelingName' on line 2198
data/modules/scripts/gamestore/init.lua|2204 col 9| shadowing upvalue 'player' on line 2199
data/modules/scripts/gamestore/init.lua|2234 col 22| shadowing upvalue argument 'playerId' on line 2231
data/modules/scripts/gamestore/init.lua|2235 col 9| shadowing upvalue 'player' on line 2232
data/modules/scripts/hirelings/hireling_module.lua|14 col 8| value assigned to variable 'outfitType' is overwritten on line 15 before use
data/npclib/npc_system/custom_modules.lua|8 col 8| value assigned to variable 'discount' is unused
data/npclib/npc_system/npc_handler.lua|596 col 3| value assigned to variable 'events' is unused
data/scripts/eventcallbacks/monster/on_spawn.lua|56 col 10| shadowing definition of argument 'monster' on line 38
data/scripts/eventcallbacks/monster/ondroploot_boosted.lua|18 col 8| variable 'mType' was previously defined on line 10
data/scripts/talkactions/gm/teleport_to_player.lua|43 col 54| shadowing upvalue argument 'player' on line 3
data/scripts/talkactions/god/add_addon.lua|32 col 8| shadowing upvalue 'addons' on line 1
data/scripts/talkactions/god/add_outfit.lua|37 col 2| unreachable code
data/scripts/talkactions/god/zones.lua|74 col 11| shadowing upvalue argument 'player' on line 3
data/scripts/talkactions/player/reward.lua|22 col 47| shadowing upvalue argument 'player' on line 14