Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "fix: rank margin top" #45

Merged
merged 3 commits into from
Nov 20, 2023
Merged

revert: "fix: rank margin top" #45

merged 3 commits into from
Nov 20, 2023

Conversation

elsongabriel
Copy link
Collaborator

@elsongabriel elsongabriel commented Nov 20, 2023

Reverts #39

it's not a good practice. because rank is a "box", it can be moved to another position.
we can adjust the pedestal top to -118px, in basic.css (#PedestalAndOnline), but, I think this is a floating pedestal.

@majestyotbr majestyotbr changed the title Revert "fix: rank margin top" revert: "fix: rank margin top" Nov 20, 2023
@LeoTKBR
Copy link
Contributor

LeoTKBR commented Nov 20, 2023

Reverts #39

it's not a good practice. because rank is a "box", it can be moved to another position. we can adjust the pedestal top to -118px, in basic.css (#PedestalAndOnline), but, I think this is a floating pedestal.

em vez de reverter porque não aplicar porque a caixa não é flutuante no visual tem um vector para "simular" que esta conectada

@elsongabriel
Copy link
Collaborator Author

Reverts #39
it's not a good practice. because rank is a "box", it can be moved to another position. we can adjust the pedestal top to -118px, in basic.css (#PedestalAndOnline), but, I think this is a floating pedestal.

em vez de reverter porque não aplicar porque a caixa não é flutuante no visual tem um vector para "simular" que esta conectada

image
esse aqui seria o vetor?
pq eu vejo que é o detalhe do box. todos tem.
então todos os boxes teriam que está conectados?

@elsongabriel elsongabriel merged commit 4bdfcdb into main Nov 20, 2023
1 check passed
@elsongabriel elsongabriel deleted the revert-39-patch-3 branch November 20, 2023 22:32
lucas-caminha pushed a commit to lucas-caminha/myaac that referenced this pull request Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants