Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

Fix: resolves #1579, #1531 #1582

Merged
merged 6 commits into from
Jul 29, 2020
Merged

Fix: resolves #1579, #1531 #1582

merged 6 commits into from
Jul 29, 2020

Conversation

marcosvf132
Copy link
Contributor

@marcosvf132 marcosvf132 commented Jul 27, 2020

This PR contains:

  • FIx on falcon teleport to oberon. Add check on teleport if player can face oberon again.

  • Fix oberon lever, now player can try to solo oberon.

Resolves #1579 #1531

@thatmichaelguy
Copy link
Contributor

I'm running this PR in production without issues, lgtm except for the minor readability comments.

@marcosvf132
Copy link
Contributor Author

I know that understand wich one is in hour or minutes is a bit hard in a full number, but the boss time are pretty standard for all boss, so i don't see any problem with that, but i understand you point of view, sometimes a more intuitive script can be better for the user.

@thatmichaelguy
Copy link
Contributor

The boss is not removed with the room clean, if one player/team fails to kill him the lever will return Someone is fighting against the boss! You need wait awhile. until he is manually removed.

@marcosvf132
Copy link
Contributor Author

I see where is the problem, the problem is not with room clean, the problem is with the server function roomIsOccupied(). I don't understand why this function is set to return false if there is any creature inside the room, a more useful function would be making this one with more option to let user choose between onlyplayer or not.

Removed function roomIsOccupied()
@majestyotbr majestyotbr changed the title Oberon fix Fix: resolves #1579, #1531 Jul 29, 2020
@majestyotbr majestyotbr merged commit fe6ba36 into opentibiabr:develop Jul 29, 2020
Costallat pushed a commit that referenced this pull request Apr 8, 2021
* Fix on falcon teleport to oberon. Add check on teleport if player can face oberon again.

* Fix oberon lever, now player can try to solo oberon.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oberon takes 5 people to enter
4 participants