Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve: implement client 12x assets protobuf reader #15

Closed
wants to merge 35 commits into from
Closed

improve: implement client 12x assets protobuf reader #15

wants to merge 35 commits into from

Conversation

marcosvf132
Copy link
Collaborator

@marcosvf132 marcosvf132 commented Apr 9, 2022 •
edited by dudantas
Loading

Description

  • Change old Remeres client .dat/.spr reader to client 12x /assets/ appeerances and sprites files.
  • Remove OTB file system.
  • Protobuf lib on remeres.
  • Update brushes and tags.

How to test so far

  1. Set your client folder to the preferences "client path"
  2. Create a brand-new map on new button on startup.
  3. Import a saved map on import map button option.

Draft

The PR is on draft due to some necessary changes:

  • Wrong outfit offset on non stantard sprite size. (Different from 32x32)
  • Paint outfit collors
  • Problem on loading Remeres icons.
  • Remove client version structure.
  • Review the entire graphics.cpp structure and functions.
  • Not saving maps

Credits

@dudantas dudantas mentioned this pull request Apr 10, 2022
Closed
@majestyotbr majestyotbr deleted the branch opentibiabr:main March 25, 2023 08:10
@majestyotbr majestyotbr reopened this Mar 25, 2023
@dudantas dudantas changed the title [Enhancement] Implement client 12x assets protobuf reader improve: implement client 12x assets protobuf reader Mar 29, 2023
@dudantas dudantas marked this pull request as ready for review March 29, 2023 02:53
dudantas and others added 20 commits March 29, 2023 07:23
@dudantas
improve: add reading client folder by properties window
7b77f8e
@dudantas
fix: materials and assets loading
10ad3b2
@dudantas
fix items palette
95c2a55
@dudantas
remove deprecated
bf502b1
@dudantas
fix compilation
23475a4
@dudantas
fix: remove libbmp and added libpng instead
af2d1fc
@dudantas
fix: compilation and warnings
dfc73e2
@dudantas
Merge branch 'main' into assets-protobuf
9fd6b61
@dudantas
fix: compilation errors
0c3a22f
@dudantas
fix: remove unused functions and fix wxWindow sprites
13b8913
@dudantas
improve: create function body
85626af
@dudantas
fix: images 64x64 on wxWindows
2d76e2e
@dudantas
improve: rename from client_version to client_assets
5eefd0f
@dudantas
fix: some item type and indentations
59c2a20
@dudantas
fix indent
ccfc7db
@dudantas
fix: change project name and some small fixes
39f5758
@dudantas
Remove some extensions
1999a13
@dudantas
fix: open window if directory client is empty
252914a
@dudantas
improve some log error
d0aad5e
@dudantas
fix: monsters draw map
4601ce6
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 204 Code Smells

0.0% 0.0% Coverage
0.9% 0.9% Duplication

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 205 Code Smells

0.0% 0.0% Coverage
0.9% 0.9% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@dudantas
Copy link
Member

New pr: #70

@dudantas dudantas closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcosvf132 @dudantas @majestyotbr