-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Statically generating opentofu releases page: Fixes opentofu/opentofu#1131 #22
Conversation
Signed-off-by: sanskruti-shahu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that this code is incomplete.
Hey @janosdebugs , For these changes to be reflected correctly you need to change/add the build command as I did same thing with my forked of opentofu/get.opentofu.org, (on my personal cloudflare acount) I added build command as Preview url: https://get-opentofu-org.pages.dev/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed the file writing, my apologies.
Signed-off-by: sanskruti-shahu <[email protected]>
Signed-off-by: sanskruti-shahu <[email protected]>
Signed-off-by: sanskruti-shahu <[email protected]>
Hey @janosdebugs , I have implemented the changes you requested. Could you please review them again? |
Hey @sanskruti-shahu please make sure that:
Please request a re-review once you have completed this for all code branches. |
Signed-off-by: sanskruti-shahu <[email protected]>
Hey @janosdebugs , According to me I have implemented the mentioned changes, Please let me know if there's still anything missing. Thanks. |
@janosdebugs , Gentle reminder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @sanskruti-shahu thank you! One tiny nit-pick and sorry for the delay.
Signed-off-by: sanskruti-shahu <[email protected]>
Note for my fellow reviewer: this code now generates the content, but we will still need to add a GitHub Actions integration. I would recommend merging into a feature branch and work from there. |
Objective
The objective of this PR is to introduce a statically generated releases page for the opentofu.
Changes
main.go
file andREADME.md
.main.go
file is responsible for fetching release information from the GitHub API and generating all required HTML pages when executed.README.md
file to provide clarity on the functionality of themain.go
file.Continuation of #16