Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improvements to feed-data script #300

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

diofeher
Copy link
Member

@diofeher diofeher commented Feb 25, 2025

This PR handles a few improvements to the feed-data script and to the Makefile.

  • Makefile generate-registry takes a long time to run. Since we're using it for fast local environment setup, we're restricting to opentofu namespace using the ad provider;
  • Wrangler r2 API does not support r2 object put for directories. We were receiving errors because of it, making the output confusing, even if it was working. I've made a refactoring to make it easier to see what the script was doing;
  • Wrangler r2 API doesn't handle well concurrent requests to r2 object put. I've refactored in order to do the adding sequentially.

Checklist

  • I have read the contribution guide.
  • I have not used an AI coding assistant to create this PR.
  • My contribution is compatible with the MPL-2.0 license and I have provided a DCO sign-off on all my commits.
  • I have written all code in this PR myself OR I have marked all code I have not written myself (including modified code, e.g. copied from other places and then modified) with a comment indicating where it came from.

@diofeher diofeher requested a review from a team February 25, 2025 19:59
@diofeher diofeher marked this pull request as draft February 26, 2025 16:08
@diofeher diofeher changed the title fix: do not run wrangler command in directories refactor: improvements to feed-data script Feb 26, 2025
@diofeher diofeher self-assigned this Feb 26, 2025
@diofeher diofeher marked this pull request as ready for review February 26, 2025 18:28
@diofeher diofeher requested a review from cam72cam February 26, 2025 18:28
@diofeher diofeher force-pushed the fix/feed-data-script branch from b8e0ae0 to 83e1530 Compare February 26, 2025 22:40
Signed-off-by: Diógenes Fernandes <[email protected]>
@diofeher diofeher force-pushed the fix/feed-data-script branch from 83e1530 to e575b62 Compare February 26, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants