-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configurable strict mode to itinerary filter #1024
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it could be helpful to have a larger discussion about what exactly we're doing here...
But in the meantime I have a few quick cleanup suggestions. Also, the new config item needs to go in the example config!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking much better! Could we possibly add comments to the rest of the new code? Since it is a little bit confusing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last cleanup!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're almost ready to go! We just need to get rid of that else block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We got there! Thanks for all your work on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, nice job!
Description:
Adds support for a config item that will filter itineraries based on exactly what modes the user has selected (eliminates walk itineraries being shown by default if user did not specifically select a walk mode)
PR Checklist:
@daniel-heppner-ibigroup also wrote this and I forgot to put him in the commit!!!