Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable strict mode to itinerary filter #1024

Merged
merged 6 commits into from
Oct 16, 2023

Conversation

amy-corson-ibigroup
Copy link
Contributor

@amy-corson-ibigroup amy-corson-ibigroup commented Oct 6, 2023

Description:

Adds support for a config item that will filter itineraries based on exactly what modes the user has selected (eliminates walk itineraries being shown by default if user did not specifically select a walk mode)

PR Checklist:

  • [n/a] Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • [n/a] Are all languages supported (Internationalization/Localization)?
  • [n/a] Are appropriate Typescript types implemented?

@daniel-heppner-ibigroup also wrote this and I forgot to put him in the commit!!!

Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could be helpful to have a larger discussion about what exactly we're doing here...

But in the meantime I have a few quick cleanup suggestions. Also, the new config item needs to go in the example config!

lib/actions/apiV2.js Outdated Show resolved Hide resolved
lib/actions/apiV2.js Show resolved Hide resolved
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking much better! Could we possibly add comments to the rest of the new code? Since it is a little bit confusing

Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last cleanup!

lib/actions/apiV2.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're almost ready to go! We just need to get rid of that else block

Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We got there! Thanks for all your work on this

Copy link
Member

@AdrianaCeric AdrianaCeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, nice job!

@amy-corson-ibigroup amy-corson-ibigroup merged commit ad14cde into dev Oct 16, 2023
7 checks passed
@amy-corson-ibigroup amy-corson-ibigroup deleted the configurable-walk-options branch October 16, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants