Use existing trip existence #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… new existence check.
miles-grant-ibigroup
approved these changes
Nov 28, 2023
This PR does not address this bug, it is a backend issue. |
daniel-heppner-ibigroup
approved these changes
Nov 29, 2023
daniel-heppner-ibigroup
assigned binh-dam-ibigroup and unassigned daniel-heppner-ibigroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the saved trip editor reuse the
itineraryExistenceobject stored in the corresponding trip, instead of starting a new check that may not complete. (When saving new trips, a new itinerary existence check will continue to be initiated.) (That's the first commit in this PR.)The PR also introduce
ItineraryExistenceandMonitoredTriptypes and applies them to select files.PR Checklist