Pattern viewer configuration and styling #1336
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miles-grant-ibigroup
requested changes
Jan 8, 2025
Comment on lines
115
to
119
| ) | ||
|
|
||
| const headsigns = sortPatternsByVehicleCount | ||
| ? unsortedHeadsigns.sort((a, b) => { | ||
| // sort by number of vehicles on that pattern |
There was a problem hiding this comment.
We can avoid adding the new variable and the ternary if you instead add an if(!sortPatternsByVehicleCount) return 0 at the top of the original sort method
There was a problem hiding this comment.
Isn't it more efficient to avoid iterating through the sort if we don't have to?
There was a problem hiding this comment.
If we always return 0 it's still O(n) and the code is much cleaner
miles-grant-ibigroup
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
sortRoutePatternsByVehicleswhich makes sorting the route patterns by vehicle count in the dropdown optional.PR Checklist:
|