-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Language server fixes #1
Conversation
these inital fixes have been done by @NLueg
@thecodemonkey try merging this into master branch, results from maven look good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I actually don't looked at every file but the implementation works perfectly with the monaco implementation.
@NLueg why is the port 31057 hard coded into |
@jages Well, that's a good point ... I hardcoded the port into But that's a good point with docker. What would you say would be a good solution for this problem? Of course, we just could add the port to docker but maybe you have a better idea for this. |
all settings in |
@NLueg please review the dependency of the specific port in the vs-code and npm package. I currently see no reason to specify the port in the config, as it can just be started in the CLI (especially in the npm package, this could be arranged to start the port with the listening port of the consumer) |
@jages I will fix the problem in both packages. But this doesn't block this PR, because the JAR is currently inserted manually in both packages. In my opinion, we can merge this. |
This addresses #2 in a small capacity. |
Description
This merges various changes from @NLueg (originially merged into
openvalidation/openvalidation:develop
) intoopenvalidation/openvalidation-rest
, from before the migration to it's own repository.There are siginificant changes to
pom.xml
, that require various changes.Due to the changes made to the underlying API this requires openvalidation PR#57 to complete.