Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the alternative reading for 聘 (fixes #362) #377

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Add the alternative reading for 聘 (fixes #362) #377

merged 1 commit into from
Oct 5, 2023

Conversation

lukhnos
Copy link
Contributor

@lukhnos lukhnos commented Oct 5, 2023

@lukhnos lukhnos requested a review from mjhsieh October 5, 2023 17:07
@lukhnos
Copy link
Contributor Author

lukhnos commented Oct 5, 2023

@ltlnx 從教育部的資料看來，聘讀作ㄆ一ㄥˋ的用法，僅限於動詞。其他聘的衍生詞，教育部重編本都只列ㄆ一ㄣˋ的讀法，所以這個 PR 就只增加字的讀音了。

mjhsieh
mjhsieh approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@mjhsieh mjhsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good according to moe.edu.tw

@lukhnos lukhnos merged commit 6aed13f into master Oct 5, 2023
1 check passed
@lukhnos lukhnos deleted the dev/add-reading branch October 5, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjhsieh mjhsieh mjhsieh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukhnos @mjhsieh