Fix phonetics for 切 #578
Merged
Fix phonetics for 切 #578
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The concise dictionary prefers `反切 ㄈㄢˇ ㄑㄧㄝˋ` Add phrses from the concise dictionary. Ref: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E5%88%87#searchL
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (2)
- Source/Data/BPMFMappings.txt: Language not supported
- Source/Data/phrase.occ: Language not supported
Code Review Agent Run #270c23Actionable Suggestions - 2
Review Details
AI Code Review powered by |
Changelist by BitoThis pull request implements the following key changes.
|
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
lukhnos
approved these changes
Feb 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The concise dictionary prefers
反切 ㄈㄢˇ ㄑㄧㄝˋAdd phrses from the concise dictionary.
Ref: https://dict.concised.moe.edu.tw/search.jsp?md=1&word=%E5%88%87#searchL
Summary by Bito
This PR enhances the phonetic mappings for the Chinese character '切' by adding multiple entries from the concise dictionary. The changes include adding Bopomofo phonetic notations for various compound words and phrases, improving the accuracy and completeness of the phonetic system. Some duplicate entries were identified in the mappings that require cleanup.Unit tests added: False
Estimated effort to review (1-5, lower is better): 2