Merge pull request #105 from openvanilla/dev/marking-fine-tunes

Put cursor at the back after marking backwards
openvanilla · Jan 15, 2024 · 33afa98 · 33afa98
2 parents c09a368 + 27b8266
commit 33afa98
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/src/KeyHandler.cpp b/src/KeyHandler.cpp
@@ -303,6 +303,14 @@ bool KeyHandler::handle(Key key, McBopomofo::InputState* state,
       if (marking->acceptable) {
         userPhraseAdder_->addUserPhrase(marking->reading, marking->markedText);
         onAddNewPhrase_(marking->markedText);
+
+        // If the cursor was at the end of the buffer when the marking started,
+        // move back.
+        if (marking->markStartGridCursorIndex == grid_.length() &&
+            grid_.cursor() < marking->markStartGridCursorIndex) {
+          grid_.setCursor(grid_.length());
+        }
+
         stateCallback(buildInputtingState());
       } else {
         errorCallback();
@@ -571,7 +579,7 @@ bool KeyHandler::handleTabKey(Key key, McBopomofo::InputState* state,
     errorCallback();
     return true;
   }
-  Formosa::Gramambular2::ReadingGrid::NodePtr currentNode = *nodeIter;
+  const Formosa::Gramambular2::ReadingGrid::NodePtr& currentNode = *nodeIter;
 
   size_t currentIndex = 0;
   if (!currentNode->isOverridden()) {
@@ -999,7 +1007,7 @@ void KeyHandler::pinNode(
   if (nodeIter == latestWalk_.nodes.cend()) {
     return;
   }
-  Formosa::Gramambular2::ReadingGrid::NodePtr currentNode = *nodeIter;
+  const Formosa::Gramambular2::ReadingGrid::NodePtr& currentNode = *nodeIter;
 
   if (currentNode != nullptr &&
       currentNode->currentUnigram().score() > kNoOverrideThreshold) {