Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Plain Bopomofo associated phrases and fix a regression #135

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Improve Plain Bopomofo associated phrases and fix a regression #135

merged 3 commits into from
Mar 21, 2024

Conversation

lukhnos
Copy link
Collaborator

@lukhnos lukhnos commented Mar 17, 2024 •
edited
Loading

This PR:

  • Now shows "S-1"…"S-9" for Shift-1…Shift-9 in Plain Bopomofo's associated phrases candidate panel. This improves the visual appearance. Note that the "S-x" label is provided by fcitx5 itself when the candidate key is a "Shift-x" key.
  • Return key is no longer accepted when Plain Bopomofo's associated phrases candidate panel is on. The Mac version never accepts the key, and so this keeps the feature in sync.
  • Also, fixes a regression where after the Associated Phrases v2 change, Plain Bopomofo associated phrases could not be used continuously (e.g. type 重 -> Shift-1 for 新 -> it supposed to show （新）聞、新（的）… and so on).

Screenshot:

image

lukhnos added 3 commits March 17, 2024 08:21
@lukhnos
Fix an associated phrases bug in Plain Bopomofo
0cb39ed 
When enabled, Associated Phrases in Plain Bopomofo should continue after
a phrase is selected. To do that, we must make sure that the correct
reading and value of each found associated phrase is obtained when
forming the associated phrase candidates.
@lukhnos
Accept no Return in Plain BPMF Associated Phrases
f13dffc
@lukhnos
Show "S+[1-9]" for Plain BPMF Associated Phrases
1fabbfb 
The "S-" prefix is short for "Shift+" and is provided by fcitx5. This is
for the displayed labels in the associated phrases candidate panel. The
actual Shift+[1-9] keys still need to be checked with a raw key's key
code.
@lukhnos lukhnos requested a review from zonble March 17, 2024 15:28
@zonble zonble merged commit 1ebe371 into master Mar 21, 2024
6 checks passed
@lukhnos lukhnos deleted the dev/fix-plain-bpmf-associated-phrases branch March 28, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zonble zonble zonble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukhnos @zonble