Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in lookup-by-value introduced in the Mac version #86

Closed
wants to merge 1 commit into from

Conversation

lukhnos
Copy link
Collaborator

@lukhnos lukhnos commented Oct 4, 2023

The code is from openvanilla/McBopomofo#372 and openvanilla/McBopomofo#374

@xatier This PR currently has CI failures from the build_archlinux job: https://github.com/openvanilla/fcitx5-mcbopomofo/actions/runs/6401004725 ; would you be able to let us know where the problem might be? Thanks!

@lukhnos lukhnos requested a review from zonble October 4, 2023 03:07
@xatier
Copy link
Contributor

xatier commented Oct 4, 2023

Yes, this is due to a missed dependency (fmt), I've added that in AUR's PKGBUILD a few days ago. Let me post a PR to sync the AUR and the PKGBUILD file in this repo.

https://aur.archlinux.org/cgit/aur.git/commit/?h=fcitx5-mcbopomofo-git&id=47e48d9a6f76395f390648175dbaa9f0f898eb0f

@lukhnos
Copy link
Collaborator Author

lukhnos commented Oct 4, 2023

I'll create a new PR since the PR got closed by #87's mentioning ("… fix #86") and since I've rebased the commit, GitHub doesn't allow me to reopen the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants