Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(cmake): upgrade googletest to v1.14.0 #94

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

xatier
Copy link
Contributor

@xatier xatier commented Dec 9, 2023

The pinned version [1] is quite old from Feb 2021.

[1] google/googletest@6092810


IMO, using the tagged version is better than using the SHA hash. Hence, I used the tagged version instead of SHA hash instructed from googletest README.

Note: It's interesting that Google folks forgot to bump the SHA hash during 12 -> 13 and 13 -> 14 bumps.

google/googletest@9d697cc
google/googletest@843976e

The current SHA hash in README (5376968f6948923e2411081fd9372e71a59d8e77) was from 11 -> 12 bump.

google/googletest@b9d2e1f


CMake added this warning since 3.27 (I'm using 3.27.9 on my Arch box).

Ref: https://gitlab.kitware.com/cmake/cmake/-/blob/master/Help/command/DEPRECATED_POLICY_VERSIONS.txt?ref_type=heads

CMake Deprecation Warning at build/_deps/googletest-src/CMakeLists.txt:4 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.  

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.
                                                                                    
                                                                                                                                                                         
CMake Deprecation Warning at build/_deps/googletest-src/googlemock/CMakeLists.txt:45 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.


CMake Deprecation Warning at build/_deps/googletest-src/googletest/CMakeLists.txt:56 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.

GoogleTest 1.14 requires CMake 3.13.
Ubuntu 22 provides CMake 3.22.1.
Ubuntu 20 provides CMake 3.16.3.

The pinned version [1] is quite old from Feb 2021.

[1] google/googletest@6092810
@xatier
Copy link
Contributor Author

xatier commented Dec 9, 2023

@lukhnos another fix for CMake warning on my box.

Eventually, we should use FindGTest (since CMake 3.20) once we deprecate Ubuntu 20 from the CI.
https://cmake.org/cmake/help/latest/module/FindGTest.html

Copy link
Collaborator

@lukhnos lukhnos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Eventually, we should use FindGTest (since CMake 3.20) once we deprecate Ubuntu 20 from the CI.

Makes sense. The more we rely on built-ins the better.

@lukhnos lukhnos merged commit 249544e into openvanilla:master Dec 10, 2023
@xatier
Copy link
Contributor Author

xatier commented Dec 11, 2023

Now I noticed that I meant upgrade googletest to v.1.14.0, not upgrade cmake to v1.14.0. My bad 😛

@lukhnos lukhnos changed the title build(cmake): upgrade cmake to v1.14.0 build(cmake): upgrade googletest to v1.14.0 Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants