build(cmake): upgrade googletest to v1.14.0 #94
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pinned version [1] is quite old from Feb 2021.
[1] google/googletest@6092810
IMO, using the tagged version is better than using the SHA hash. Hence, I used the tagged version instead of SHA hash instructed from
googletest README
.Note: It's interesting that Google folks forgot to bump the SHA hash during 12 -> 13 and 13 -> 14 bumps.
google/googletest@9d697cc
google/googletest@843976e
The current SHA hash in README (5376968f6948923e2411081fd9372e71a59d8e77) was from 11 -> 12 bump.
google/googletest@b9d2e1f
CMake added this warning since
3.27
(I'm using3.27.9
on my Arch box).Ref: https://gitlab.kitware.com/cmake/cmake/-/blob/master/Help/command/DEPRECATED_POLICY_VERSIONS.txt?ref_type=heads
GoogleTest 1.14 requires CMake 3.13.
Ubuntu 22 provides CMake 3.22.1.
Ubuntu 20 provides CMake 3.16.3.