RH dockerfile update #2628
Open
RH dockerfile update #2628
+28
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first patch in a series that updates Dockerfile.redhat. This first patch does the following: 1) Replace all yum commands to dnf commands 2) Discards installing yum-utils 3) Changes removing the yum cache to dnf clean all 4) No longer download cmake since 8.10's is newer 5) Use UBI 8's ccache instead of downloading and building one 6) Drop codeready-builder-for-rhel-8-x86_64-rpms since it's not in the image 7) Enable up to 8 parallel downloads 8) In the release image also add --nodocs to save size
Sometimes cudnn fails to download. This causes the transaction to fail, however, yum/dnf both return 0. This means that the build continues until it fails to build the cuda wheel which is much later in the build. With this patch applied, it stops the build if everything did not download.
Add parallelism to building pugixml. Also group the license copy with the other copies.
One of the files needs permissions adjusted.
The default points to master, but the current branch is main. This points them to the right place by default.
This reverts commit 3ab9022.
In order to try to get installation of cudnn to be successful add more retries. Also add these into the release image so that cudnn does fail this late into the build.
Looks like it was removed betwen 2024.2 and current code. Remove it to match the current design.
|
This patch set is complete and has been verified to build using podman. |
mzegla
approved these changes
Aug 21, 2024
Make sure the additions to the dnf.conf get expanded so they get parsed correctly.
|
I think I need to start this over. Many changes were made to the docker file before this was reviewed. I'll leave it open for now. But I'll do this next time one patch at a time. |
|
Put the conversion to dnf in PR #2693. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a series of patches that update Dockerfile.redhat.