-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Good First Issue]: Verify phi-2 with GenAI text_generation #274
Comments
.take |
Thank you for looking into this issue! Please let us know if you have any questions or require any help. |
Hello @qxprakash, are you still working on this? Is there anything we could help you with? |
hello @p-wysocki yes I am working on it , I have managed to run phi-2 successfully using greedy_causal_lm.cpp and beam_search_causal_lm.cpp , decent responses and speed , I added tests for it and ran the github actions workflow in my own fork , the issue was I always kept getting this message in my workflow ---
the runners never picked up the job I changed the runner to just ubuntu and tests ran successfully. should I submit a PR , with my tests workflow in which runner -- ubuntu-20.04-16-cores or ubuntu ? |
We're usually testing the changes first locally, and then in the actual Pull Request made to OpenVINO master. Please don't change the runner and submit a PR with your changes - the tests will run correctly, no need to worry about that. :) |
ok sure @p-wysocki |
@p-wysocki I have added and tested locally the cpp-beam_search tests for phi-2 , into the github actions workflow , taking reference from issue description at #259 , and updated the model list in the README.md , is there anything else I have to add or should I submit the PR with these changes. |
Context
This task regards enabling tests for phi-2. You can find more details under openvino_notebooks LLM question answering README.md.
Please ask general questions in the main issue at #259
What needs to be done?
Described in the main Discussion issue at: #259
Example Pull Requests
Described in the main Discussion issue at: #259
Resources
Contact points
Described in the main Discussion issue at: #259
Ticket
No response
The text was updated successfully, but these errors were encountered: