Verify phi-2 #299
Merged
Verify phi-2 #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-lavrenov
approved these changes
Mar 12, 2024
|
@p-wysocki should I also verify Phi-1.5 ? |
|
Thank you for your contribution! Sure, @Wovchena mentioned that contributors may propose their own models. :) Do you want me to create a Good First Issue for you? |
|
Thanks for the guidance @p-wysocki , I will create an issue by myself , based on the template for verifying models. |
|
Awesome, thanks! You can use the Good First Issue template and fill it just like the issue you completed. :) |
|
Ok sure @p-wysocki |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #274 , I have updated the model list , and added tests taking reference from issue description at #259 , @p-wysocki @ilya-lavrenov @pavel-esir in the readme I have added phi separately , since there are other phi models as well , like phi-1.5 which can be added in the future , please let me know if anything else can be done.