-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate SSD from mmdet to OTX #3279
Migrate SSD from mmdet to OTX #3279
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3279 +/- ##
===========================================
- Coverage 78.39% 77.37% -1.02%
===========================================
Files 179 185 +6
Lines 15169 16042 +873
===========================================
+ Hits 11891 12413 +522
- Misses 3278 3629 +351
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems we don't need to type
for modules in the recipe if using specific modules, not popping it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please confirm if you intend to separate these mmdetection modules in the upcoming PR?
from mmdet.models.losses import smooth_l1_loss
from mmdet.models.task_modules.assigners.assign_result import AssignResult
from mmdet.models.task_modules.samplers import PseudoSampler
from mmdet.models.utils import multi_apply
from mmdet.models.utils import filter_scores_and_topk, select_single_mlvl, unpack_gt_instances
from mmdet.models.dense_heads.base_dense_head import BaseDenseHead
from mmdet.models.task_modules.prior_generators import AnchorGenerator, anchor_inside_flags
from mmdet.models.task_modules.samplers import PseudoSampler
from mmdet.models.utils import images_to_levels, multi_apply, unmap
from mmcv.ops import batched_nms
Current PR scope is bringing model architecture things, and after this PR I'll bring ops and data structures. |
Summary
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.