Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞Remove Draem + fix tests #3296

Conversation

ashwinvaidya17
Copy link
Contributor

Summary

Should address #3277

Note: I have removed Draem model as it is not exposed to Geti yet and just increases the testing time. We can re-introduce if we plan to add it to Geti and once the Geti tasks are ready.

How to test

tox -vv -e e2e-test-anomaly
image

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

Signed-off-by: Ashwin Vaidya <[email protected]>
@ashwinvaidya17
Copy link
Contributor Author

Pre-commit checks are passing locally with both tox and by using pre-commit
image

jaegukhyun
jaegukhyun previously approved these changes Apr 11, 2024
@ashwinvaidya17 ashwinvaidya17 changed the base branch from develop to releases/2.0.0 April 11, 2024 13:53
@ashwinvaidya17 ashwinvaidya17 dismissed jaegukhyun’s stale review April 11, 2024 13:53

The base branch was changed.

@ashwinvaidya17 ashwinvaidya17 changed the base branch from releases/2.0.0 to develop April 11, 2024 13:55
@ashwinvaidya17
Copy link
Contributor Author

I'll recreate the PR to target release 2.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUILD TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants