-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor checkpiont logic #3302
Merged
vinnamkim
merged 10 commits into
openvinotoolkit:develop
from
vinnamkim:refactor-checkpoint-logic
Apr 15, 2024
Merged
Refactor checkpiont logic #3302
vinnamkim
merged 10 commits into
openvinotoolkit:develop
from
vinnamkim:refactor-checkpoint-logic
Apr 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kim, Vinnam <[email protected]>
Signed-off-by: Kim, Vinnam <[email protected]>
vinnamkim
requested review from
samet-akcay,
harimkang,
jaegukhyun,
sungmanc,
eugene123tw,
kprokofi,
chuneuny-emily and
sovrasov
as code owners
April 11, 2024 10:21
Signed-off-by: Kim, Vinnam <[email protected]>
Signed-off-by: Kim, Vinnam <[email protected]>
…int-logic Signed-off-by: Kim, Vinnam <[email protected]>
Signed-off-by: Kim, Vinnam <[email protected]>
Signed-off-by: Kim, Vinnam <[email protected]>
8 tasks
Signed-off-by: Kim, Vinnam <[email protected]>
…int-logic Signed-off-by: Kim, Vinnam <[email protected]>
vinnamkim
force-pushed
the
refactor-checkpoint-logic
branch
from
April 15, 2024 02:12
051caa9
to
c96258e
Compare
Signed-off-by: Kim, Vinnam <[email protected]>
jaegukhyun
reviewed
Apr 15, 2024
harimkang
approved these changes
Apr 15, 2024
jaegukhyun
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ticket no. 138353
The main objective of this PR is to modify the logic for saving and loading model checkpoints in a manner that aligns more closely with the recommendations from PyTorch Lightning. We need to customize them to package our metadata objects (
label_info
,otx_version
, ...). For more information, refer to the following PyTorch Lightning documentation:Another motivation for this change is to prevent errors during PyTorch tracing. If we manually include an arbitrary object that is not an
nn.Parameter
innn.Module.state_dict()
, it triggers an error when executingtorch.onnx.export
.Additionally, this PR revisits the
Engine
pipelines to address the following TODO comments in the code:training_extensions/src/otx/engine/engine.py
Lines 437 to 438 in e8e5673
How to test
Also modified the existing tests according to this change.
Checklist
License
Feel free to contact the maintainers if that's a concern.