Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Refactor Anomaly Models #4102

Merged

Conversation

ashwinvaidya17
Copy link
Collaborator

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

Signed-off-by: Ashwin Vaidya <[email protected]>
@sovrasov
Copy link
Contributor

sovrasov commented Nov 6, 2024

@ashwinvaidya17 would that be compatible with Geti?

@harimkang
Copy link
Contributor

@ashwinvaidya17 would that be compatible with Geti?

As far as I can see, there are no input changes, it's mainly a refactoring inside the model, so it probably won't affect Geti.
@ashwinvaidya17 Could you confirm?

Copy link
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please take a look at the unit-test fail.

@harimkang
Copy link
Contributor

  • @ashwinvaidya17 Another question, when will we be able to upgrade to the latest version of anomalib in otx?

We also have the following request from a user, Could you please check it out?
#3971

@ashwinvaidya17
Copy link
Collaborator Author

Yeah. Only the methods have been moved around a bit.

@sovrasov sovrasov merged commit fc221e8 into openvinotoolkit:develop Nov 19, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants