Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close BluetoothGatt after disconnect. #382

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Close BluetoothGatt after disconnect. #382

merged 1 commit into from
Oct 13, 2023

Conversation

dyiop
Copy link
Contributor

@dyiop dyiop commented Oct 10, 2023 •
edited by suzannajiwani
Loading

This would cause issues on some readers with some devices. Left previous connection open and was prone to further unexpected communications.

  • Tests pass
  • Appropriate changes to README are included in PR

@dyiop
Close BluetoothGatt after disconnect.
eaf15c0 
This would cause issues on some readers with some devices. Left previous connection open and was prone to further unexpected communications.
@dyiop dyiop requested a review from davidz25 October 10, 2023 17:15
davidz25
davidz25 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@davidz25 davidz25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@davidz25 davidz25 merged commit f9c5bcb into master Oct 13, 2023
5 checks passed
@dyiop dyiop deleted the close-gatt-after-disconnect branch October 13, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidz25 davidz25 davidz25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dyiop @davidz25