Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update manage script to automate set-up #219

Merged

Conversation

esune
Copy link
Member

@esune esune commented Feb 7, 2023

The manage script has updated to automate the steps to start-up vc-authn in various modes:

  • the user will be prompted to select whether they want to run in single-tenant or multi-tenant/traction mode
  • the user will be prompted to choose whether to use ngrok to expose the services or not

Both curl and jq are being executed in a docker container, removing the dependency for separate binaries on the path.

Ngrok containers have been moved to a separate compose project file: they need to be started before all of the other services in order to retrieve the public URLs and use set environment variables using their values.

I have not been able to test whether this works with traction or not as I cannot start the project in its current state - @Jsyro please let me know if you can run the code and it works.

Resolves #210

@esune esune requested review from Jsyro and WadeBarnes February 7, 2023 01:40
@esune esune force-pushed the feature/script-updates branch from 768c884 to 2099ff1 Compare February 7, 2023 01:44
esune added 3 commits February 6, 2023 17:57
Signed-off-by: Emiliano Suñé <[email protected]>
Signed-off-by: Emiliano Suñé <[email protected]>
@esune esune marked this pull request as ready for review February 7, 2023 18:38
@esune
Copy link
Member Author

esune commented Feb 7, 2023

I am still trying to upgrade the ngrok containers to use the official, more regent image. Other than that the changes should be good to go.

Copy link
Contributor

@Jsyro Jsyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When using the 'multi-tenant' option, I ran into two issues. See comments.

docker/manage Show resolved Hide resolved
docker/manage Outdated Show resolved Hide resolved
@esune
Copy link
Member Author

esune commented Feb 7, 2023

It looks like there is an issue with the newer ngrok images, I will wait until that is resolved before I attempt to upgrade again the configuration. See ngrok/docker-ngrok#25

@esune esune requested a review from Jsyro February 8, 2023 17:17
@esune
Copy link
Member Author

esune commented Feb 8, 2023

Added some tweaks that should make quality of life better when restarting the project while keeping the same settings, and refreshing ngrok endpoints if necessary. If this gets us close enough to where we want to be I'd lean towards merging/closing and logging more specific issues about what needs tweaking as we find out.

Signed-off-by: Emiliano Suñé <[email protected]>
@esune esune force-pushed the feature/script-updates branch from 40840b6 to b383d71 Compare February 8, 2023 21:13
esune added 2 commits February 8, 2023 13:20
Signed-off-by: Emiliano Suñé <[email protected]>
Copy link
Contributor

@Jsyro Jsyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes, still some minor exceptions I need for my development environment, but this should work for everyone else.

@Jsyro Jsyro merged commit 512884d into openwallet-foundation:2.0-development Feb 8, 2023
@esune esune deleted the feature/script-updates branch February 8, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants