Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change did:tdw resolver naming to did:webvh #3429

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

jamshale
Copy link
Contributor

@jamshale jamshale commented Jan 7, 2025

Changes the tdw resolver to the new webvh naming.

@dbluhm dbluhm merged commit 73c70ee into openwallet-foundation:main Jan 10, 2025
11 checks passed
@ff137
Copy link
Contributor

ff137 commented Jan 28, 2025

did-webvh is a blocker for running with the latest askar version, as noted here: decentralized-identity/didwebvh-py#18

A new release for did-webvh is not immediately possible, so a did-tdw release was prepared instead: decentralized-identity/didwebvh-py#20

did-tdw 0.2.2 is on pypi but did-webvh is still 0.2.1

With all that said -
There is a critical scalability fix in the latest askar release: openwallet-foundation/askar#350
And we can't upgrade askar along with did-webvh, yet - but we can with did-tdw 0.2.2

So @jamshale @swcurran @dbluhm I would like to propose reverting this PR, meaning the old did-tdw name will be used in the meantime, so that we can upgrade askar to the latest release instead.

A side-effect is this will unblock #3173, which has been waiting 6 months for a new askar release (!)

If it causes unnecessary work to revert this, and a new did-webvh release can be prepared in due time, then I'd say that's ok, and up to you whether we wait or not. I can pull all the upgrades into our acapy fork manually. I'm just looking forward to rebasing our fork being less of a headache 😄 since we're using #3173 and a bunch of other customized things.

@jamshale
Copy link
Contributor Author

We should be able to get a new release of did_webvh out soon. I'd rather not revert this. I'm not sure what's taking so long to get a simple askar upgrade for did_webvh.

This has been a bit more annoying than I thought, though. It might be better to completely remove the resolver from acapy and only have it in the plugin instead.

@ff137
Copy link
Contributor

ff137 commented Jan 28, 2025

Alright -- I see that decentralized-identity/didwebvh-py#19 has gotten a few approvals since I last looked yesterday, so hopefully a new did-webvh release is just around the corner

@jamshale
Copy link
Contributor Author

I don't know why but the did_webvh 0.2.2 library publish failed. Just trying to get it published and then we can get askar upgraded. We don't need the big PR finished to move ahead on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants