fix: ensure profile names are unique #3470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll look into why that test is failing... |
|
So... Maybe this could be done better but the This is why the failing test is happening. It's reloading the sub-wallet profile as Anoncreds and then getting the sub-wallet name again instead of the id. |
jamshale
approved these changes
Jan 27, 2025
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
dbluhm
force-pushed
the
fix/unique-profile-name
branch
from
4042125 to
3f80a4d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
profile.nameproperty is expected to be unique. When using single-wallet-askar, it is not unique and is alwaysmultitenant_sub_walletor whatever the wallet for all the profiles is called. This causes problems in a few key areas. This fix uses the profile_id (when present, i.e. when using single-wallet-askar) to make sure profile.name is unique. I will open an issue to further detail the extent of this problem so we can discuss how far back we need to go.