-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: proof request missing attribute #1307
fix: proof request missing attribute #1307
Conversation
Signed-off-by: al-rosenthal <[email protected]>
Signed-off-by: al-rosenthal <[email protected]>
Signed-off-by: al-rosenthal <[email protected]>
Signed-off-by: al-rosenthal <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1307 +/- ##
==========================================
- Coverage 57.12% 56.80% -0.32%
==========================================
Files 204 213 +9
Lines 6980 7410 +430
Branches 1978 2096 +118
==========================================
+ Hits 3987 4209 +222
- Misses 2971 3179 +208
Partials 22 22 ☔ View full report in Codecov by Sentry. |
Signed-off-by: al-rosenthal <[email protected]>
Signed-off-by: al-rosenthal <[email protected]>
Signed-off-by: al-rosenthal <[email protected]>
Signed-off-by: al-rosenthal <[email protected]>
Signed-off-by: al-rosenthal <[email protected]>
Signed-off-by: al-rosenthal <[email protected]>
Signed-off-by: al-rosenthal <[email protected]>
Signed-off-by: al-rosenthal <[email protected]>
Signed-off-by: al-rosenthal <[email protected]>
Signed-off-by: al-rosenthal <[email protected]>
Looks good |
Signed-off-by: al-rosenthal <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple questions, but otherwise a well executed tricky change 😎
const backgroundColorIfErrorState = (backgroundColor?: string) => | ||
error || predicateError || isProofRevoked ? ColorPallet.notification.errorBorder : backgroundColor | ||
|
||
const backgroundColorIfRevoked = (backgroundColor?: string) => | ||
isProofRevoked ? ColorPallet.notification.errorBorder : backgroundColor | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we get rid of backgroundColorIfErrorState
entirely if it's only being used in that fontColorWithHighContrast
function and just use the new backgroundColorIfRevoked
? Have you checked that it looks right when a credential is just missing entirely?
Summary of Changes
Related Issues
BC Wallet: 2208
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-by
line (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.