Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display revoked text and icon in ProofChangeCredential screen #1419

Conversation

ClaudeArs
Copy link
Contributor

@ClaudeArs ClaudeArs commented Jan 30, 2025

Summary of Changes

Display revoked text and icon in ProofChangeCredential screen if card is revoked.

Screenshots, videos, or gifs

Before:

After:

Breaking change guide

N/A

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this)
  • If applicable, screenshots, gifs, or video are included for UI changes
  • If applicable, breaking changes are described above along with how to address them
  • Updated documentation as needed for changed code and new or modified features
  • Added sufficient tests so that overall code coverage is not reduced

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated checks have passed

@ClaudeArs ClaudeArs requested a review from a team as a code owner January 30, 2025 14:02
@fc-santos fc-santos changed the title feat: display revoked icon in ProofChangeCredential screen if card is… feat: display revoked icon in ProofChangeCredential screen Jan 30, 2025
@bryce-mcmath
Copy link
Contributor

@ClaudeArs possible to add a before / after in the "Screenshots, videos, or gifs" section of the PR description?

@fc-santos fc-santos changed the title feat: display revoked icon in ProofChangeCredential screen feat: display revoked text and icon in ProofChangeCredential screen Jan 30, 2025
Copy link
Contributor

@bryce-mcmath bryce-mcmath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! ⚾️

@bryce-mcmath bryce-mcmath merged commit c65cbd8 into openwallet-foundation:main Jan 30, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants