Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: address pex fixes #2104

Merged
merged 2 commits into from
Nov 24, 2024
Merged

fix: address pex fixes #2104

merged 2 commits into from
Nov 24, 2024

Conversation

TimoGlastra
Copy link
Contributor

Fixes several issues found with PEX when requeting multiple credentials and only one is present.

Depends on Sphereon-Opensource/PEX#187, but I've created a temporary release under @animo-id/pex so we don't have to wait with merging. Once it's merged and release in official PEX repo I'll revert back to the Sphereon version.

Also adds some new tests for PEX

@TimoGlastra
fix: address pex fixes
8257e25 
Signed-off-by: Timo Glastra <[email protected]>
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 23, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5be6501

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TimoGlastra TimoGlastra merged commit e70a2ce into openwallet-foundation:main Nov 24, 2024
12 of 14 checks passed
@TimoGlastra TimoGlastra deleted the fix/pex-fixes branch November 24, 2024 12:01
TimoGlastra added a commit that referenced this pull request Nov 24, 2024
@Tommylans @TimoGlastra
chore: Update branch with main (#2106)
367dfa2 
* chore: return access token response (#2097)

Signed-off-by: Timo Glastra <[email protected]>

* fix: exp encoding (#2101)

Signed-off-by: Timo Glastra <[email protected]>

* fix: mdoc patches (#2102)

Signed-off-by: Timo Glastra <[email protected]>

* fix: address pex fixes (#2104)

Signed-off-by: Timo Glastra <[email protected]>

---------

Signed-off-by: Timo Glastra <[email protected]>
Co-authored-by: Timo Glastra <[email protected]>
berendsliedrecht pushed a commit to berendsliedrecht/credo-ts that referenced this pull request Nov 25, 2024
@TimoGlastra @berendsliedrecht
fix: address pex fixes (openwallet-foundation#2104)
6642ea0 
Signed-off-by: Timo Glastra <[email protected]>
TimoGlastra added a commit to animo/aries-framework-javascript that referenced this pull request Nov 26, 2024
@TimoGlastra
Squashed commit of the following:
dc81f25 
commit c3939b2
Author: Tom Lanser <[email protected]>
Date:   Tue Nov 26 10:43:35 2024 +0100

    chore: Bumped the federation package

    Signed-off-by: Tom Lanser <[email protected]>

commit 623c3b7
Author: Tom Lanser <[email protected]>
Date:   Tue Nov 26 10:41:40 2024 +0100

    fix: Apply withEntityId patch for the normal version

    Signed-off-by: Tom Lanser <[email protected]>

commit 262ee63
Merge: 94d22bd 8da4250
Author: Tom Lanser <[email protected]>
Date:   Mon Nov 25 22:27:37 2024 +0100

    Merge branch 'feature/openid-federation-verfier--openwallet' into feature/openid-federation-verfier--animo

commit 8da4250
Author: Tom Lanser <[email protected]>
Date:   Mon Nov 25 14:44:43 2024 +0100

    feat: Support for subordinate entities and authority hints (openwallet-foundation#2107)

    * feat: Support for subordinate entities and authority hints

    Signed-off-by: Tom Lanser <[email protected]>

    * fix: Increased the openid fed version

    Signed-off-by: Tom Lanser <[email protected]>

    * feat: tests for multiple layers

    Signed-off-by: Tom Lanser <[email protected]>

    ---------

    Signed-off-by: Tom Lanser <[email protected]>

commit 274b421
Author: Timo Glastra <[email protected]>
Date:   Sun Nov 24 16:52:08 2024 +0100

    update lockfile

    Signed-off-by: Timo Glastra <[email protected]>

commit ff73f53
Merge: 367dfa2 e70a2ce
Author: Timo Glastra <[email protected]>
Date:   Sun Nov 24 16:00:28 2024 +0100

    Merge branch 'main' into feature/openid-federation-verfier

    Signed-off-by: Timo Glastra <[email protected]>

commit 367dfa2
Author: Tom Lanser <[email protected]>
Date:   Sun Nov 24 15:59:27 2024 +0100

    chore: Update branch with main (openwallet-foundation#2106)

    * chore: return access token response (openwallet-foundation#2097)

    Signed-off-by: Timo Glastra <[email protected]>

    * fix: exp encoding (openwallet-foundation#2101)

    Signed-off-by: Timo Glastra <[email protected]>

    * fix: mdoc patches (openwallet-foundation#2102)

    Signed-off-by: Timo Glastra <[email protected]>

    * fix: address pex fixes (openwallet-foundation#2104)

    Signed-off-by: Timo Glastra <[email protected]>

    ---------

    Signed-off-by: Timo Glastra <[email protected]>
    Co-authored-by: Timo Glastra <[email protected]>

commit 11455b5
Author: Tom Lanser <[email protected]>
Date:   Thu Nov 21 15:26:32 2024 +0100

    fix: OpenID Federation small fixes (openwallet-foundation#2099)

    * fix: Use the right fingerprint for the RP kid

    Signed-off-by: Tom Lanser <[email protected]>

    * fix: Use mergedproperties

    Signed-off-by: Tom Lanser <[email protected]>

    ---------

    Signed-off-by: Tom Lanser <[email protected]>

commit 94d22bd
Author: Tom Lanser <[email protected]>
Date:   Thu Nov 21 11:55:42 2024 +0100

    fix: Use the right fingerprint for the RP kid

    Signed-off-by: Tom Lanser <[email protected]>

commit d5ea627
Author: Timo Glastra <[email protected]>
Date:   Wed Nov 20 14:00:04 2024 +0100

    update lock

    Signed-off-by: Timo Glastra <[email protected]>

commit 4515ad2
Merge: b2b3890 607659a
Author: Timo Glastra <[email protected]>
Date:   Wed Nov 20 13:58:08 2024 +0100

    Merge branch 'main' into feature/openid-federation-verfier

    Signed-off-by: Timo Glastra <[email protected]>

commit b2b3890
Author: Tom Lanser <[email protected]>
Date:   Wed Nov 20 12:01:34 2024 +0100

    feat: Added fetchEntityConfiguration

    Signed-off-by: Tom Lanser <[email protected]>

commit f6f766d
Author: Tom Lanser <[email protected]>
Date:   Wed Nov 20 11:08:34 2024 +0100

    fix: Merge conflict and changes

    Signed-off-by: Tom Lanser <[email protected]>

commit 8bb4564
Merge: 2b8bde5 17ec6b8
Author: Tom Lanser <[email protected]>
Date:   Tue Nov 19 15:12:36 2024 +0100

    Merge branch 'main' into feature/openid-federation-verfier

commit 2b8bde5
Author: Tom Lanser <[email protected]>
Date:   Mon Nov 18 16:30:07 2024 +0100

    feat: Holder side api for getting more context information

    Signed-off-by: Tom Lanser <[email protected]>

commit b06c546
Author: Tom Lanser <[email protected]>
Date:   Mon Nov 18 15:29:32 2024 +0100

    chore: Made some things more logic

    Signed-off-by: Tom Lanser <[email protected]>

commit cb6d70f
Author: Tom Lanser <[email protected]>
Date:   Mon Nov 18 14:51:43 2024 +0100

    feat: Added more logging and added unhappy tests

    Signed-off-by: Tom Lanser <[email protected]>

commit dcd810d
Author: Tom Lanser <[email protected]>
Date:   Mon Nov 18 12:37:18 2024 +0100

    feat: Processed feedback and used the right keys for the verifier

    Signed-off-by: Tom Lanser <[email protected]>

commit 1743fb1
Author: Tom Lanser <[email protected]>
Date:   Thu Nov 7 11:42:02 2024 +0100

    fix: typescript error

    Signed-off-by: Tom Lanser <[email protected]>

commit bcaed4d
Author: Tom Lanser <[email protected]>
Date:   Wed Nov 6 20:49:29 2024 +0100

    feat: Littlebit of a cleanup for the verifier

    Signed-off-by: Tom Lanser <[email protected]>

commit b723485
Author: Tom Lanser <[email protected]>
Date:   Tue Nov 5 11:34:39 2024 +0100

    feat: working version

    Signed-off-by: Tom Lanser <[email protected]>
TimoGlastra added a commit to animo/aries-framework-javascript that referenced this pull request Nov 26, 2024
@TimoGlastra
Squashed commit of the following:
ad5e11c 
commit c3939b2
Author: Tom Lanser <[email protected]>
Date:   Tue Nov 26 10:43:35 2024 +0100

    chore: Bumped the federation package

    Signed-off-by: Tom Lanser <[email protected]>

commit 623c3b7
Author: Tom Lanser <[email protected]>
Date:   Tue Nov 26 10:41:40 2024 +0100

    fix: Apply withEntityId patch for the normal version

    Signed-off-by: Tom Lanser <[email protected]>

commit 262ee63
Merge: 94d22bd 8da4250
Author: Tom Lanser <[email protected]>
Date:   Mon Nov 25 22:27:37 2024 +0100

    Merge branch 'feature/openid-federation-verfier--openwallet' into feature/openid-federation-verfier--animo

commit 8da4250
Author: Tom Lanser <[email protected]>
Date:   Mon Nov 25 14:44:43 2024 +0100

    feat: Support for subordinate entities and authority hints (openwallet-foundation#2107)

    * feat: Support for subordinate entities and authority hints

    Signed-off-by: Tom Lanser <[email protected]>

    * fix: Increased the openid fed version

    Signed-off-by: Tom Lanser <[email protected]>

    * feat: tests for multiple layers

    Signed-off-by: Tom Lanser <[email protected]>

    ---------

    Signed-off-by: Tom Lanser <[email protected]>

commit 274b421
Author: Timo Glastra <[email protected]>
Date:   Sun Nov 24 16:52:08 2024 +0100

    update lockfile

    Signed-off-by: Timo Glastra <[email protected]>

commit ff73f53
Merge: 367dfa2 e70a2ce
Author: Timo Glastra <[email protected]>
Date:   Sun Nov 24 16:00:28 2024 +0100

    Merge branch 'main' into feature/openid-federation-verfier

    Signed-off-by: Timo Glastra <[email protected]>

commit 367dfa2
Author: Tom Lanser <[email protected]>
Date:   Sun Nov 24 15:59:27 2024 +0100

    chore: Update branch with main (openwallet-foundation#2106)

    * chore: return access token response (openwallet-foundation#2097)

    Signed-off-by: Timo Glastra <[email protected]>

    * fix: exp encoding (openwallet-foundation#2101)

    Signed-off-by: Timo Glastra <[email protected]>

    * fix: mdoc patches (openwallet-foundation#2102)

    Signed-off-by: Timo Glastra <[email protected]>

    * fix: address pex fixes (openwallet-foundation#2104)

    Signed-off-by: Timo Glastra <[email protected]>

    ---------

    Signed-off-by: Timo Glastra <[email protected]>
    Co-authored-by: Timo Glastra <[email protected]>

commit 11455b5
Author: Tom Lanser <[email protected]>
Date:   Thu Nov 21 15:26:32 2024 +0100

    fix: OpenID Federation small fixes (openwallet-foundation#2099)

    * fix: Use the right fingerprint for the RP kid

    Signed-off-by: Tom Lanser <[email protected]>

    * fix: Use mergedproperties

    Signed-off-by: Tom Lanser <[email protected]>

    ---------

    Signed-off-by: Tom Lanser <[email protected]>

commit 94d22bd
Author: Tom Lanser <[email protected]>
Date:   Thu Nov 21 11:55:42 2024 +0100

    fix: Use the right fingerprint for the RP kid

    Signed-off-by: Tom Lanser <[email protected]>

commit d5ea627
Author: Timo Glastra <[email protected]>
Date:   Wed Nov 20 14:00:04 2024 +0100

    update lock

    Signed-off-by: Timo Glastra <[email protected]>

commit 4515ad2
Merge: b2b3890 607659a
Author: Timo Glastra <[email protected]>
Date:   Wed Nov 20 13:58:08 2024 +0100

    Merge branch 'main' into feature/openid-federation-verfier

    Signed-off-by: Timo Glastra <[email protected]>

commit b2b3890
Author: Tom Lanser <[email protected]>
Date:   Wed Nov 20 12:01:34 2024 +0100

    feat: Added fetchEntityConfiguration

    Signed-off-by: Tom Lanser <[email protected]>

commit f6f766d
Author: Tom Lanser <[email protected]>
Date:   Wed Nov 20 11:08:34 2024 +0100

    fix: Merge conflict and changes

    Signed-off-by: Tom Lanser <[email protected]>

commit 8bb4564
Merge: 2b8bde5 17ec6b8
Author: Tom Lanser <[email protected]>
Date:   Tue Nov 19 15:12:36 2024 +0100

    Merge branch 'main' into feature/openid-federation-verfier

commit 2b8bde5
Author: Tom Lanser <[email protected]>
Date:   Mon Nov 18 16:30:07 2024 +0100

    feat: Holder side api for getting more context information

    Signed-off-by: Tom Lanser <[email protected]>

commit b06c546
Author: Tom Lanser <[email protected]>
Date:   Mon Nov 18 15:29:32 2024 +0100

    chore: Made some things more logic

    Signed-off-by: Tom Lanser <[email protected]>

commit cb6d70f
Author: Tom Lanser <[email protected]>
Date:   Mon Nov 18 14:51:43 2024 +0100

    feat: Added more logging and added unhappy tests

    Signed-off-by: Tom Lanser <[email protected]>

commit dcd810d
Author: Tom Lanser <[email protected]>
Date:   Mon Nov 18 12:37:18 2024 +0100

    feat: Processed feedback and used the right keys for the verifier

    Signed-off-by: Tom Lanser <[email protected]>

commit 1743fb1
Author: Tom Lanser <[email protected]>
Date:   Thu Nov 7 11:42:02 2024 +0100

    fix: typescript error

    Signed-off-by: Tom Lanser <[email protected]>

commit bcaed4d
Author: Tom Lanser <[email protected]>
Date:   Wed Nov 6 20:49:29 2024 +0100

    feat: Littlebit of a cleanup for the verifier

    Signed-off-by: Tom Lanser <[email protected]>

commit b723485
Author: Tom Lanser <[email protected]>
Date:   Tue Nov 5 11:34:39 2024 +0100

    feat: working version

    Signed-off-by: Tom Lanser <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TimoGlastra