Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent infinite loop bug when index.html is missed #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Prevent infinite loop bug when index.html is missed #2

wants to merge 2 commits into from

Conversation

AntonioArts
Copy link

No description provided.

@mod
Copy link
Contributor

mod commented Mar 4, 2019

I will need a go based solution, not at the container level
the container is suppose to mount volume and there is no reason it will be on /usr/share/httpd

1- first fix the infinte loop in the correct function, if index.html request a redirection because file is missing then we need to show an internal server error 500
2- when the server starts verify that index.html exists before starting

@AntonioArts AntonioArts changed the title Add default index.html and not found 404.html Handle index.html missing, handle page not found 404 Mar 4, 2019
@AntonioArts
Copy link
Author

I will need a go based solution, not at the container level
the container is suppose to mount volume and there is no reason it will be on /usr/share/httpd

/usr/share/httpd it's a hardcoded root for serving files.

@AntonioArts
Copy link
Author

AntonioArts commented Mar 4, 2019

Added server startup check if index.html exists. Without mounted httpd folder server won't start because of lack of index.html file. So this only possible solution for now

Added 404 page not found error if file do not exists.

@AntonioArts AntonioArts changed the title Handle index.html missing, handle page not found 404 Prevent infinite loop bug when index.html is missed Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants