Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iputils: install ping, ping6, traceroute6 with setuid root #854

Closed
wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 8, 2018

these utilities need to run with uid 0 to be useful. Thus,
install them setuid root like other distros do, too.

Signed-off-by: Carsten Wolff [email protected]

these utilities need to run with uid 0 to be useful. Thus,
install them setuid root like other distros do, too.

Signed-off-by: Carsten Wolff <[email protected]>
@diizzyy
Copy link
Contributor

diizzyy commented Apr 8, 2018

Out of curiosity, is this something you use?
It's very outdated (compared to upstream) so please update if you can.

@ghost
Copy link
Author

ghost commented Apr 8, 2018

I use it for the packaging of backuppc (see openwrt/packages#5886). I did not want to run backuppc as root, so it runs as a user "backuppc". Before starting a backup, backuppc runs ping to check if the client host is alive. "ping" in busybox also needs uid 0, but setting the uid bit on busybox is not an option. So I chose to depend on iputils-ping and make it setuid root, like e.g. debian does it. I assumed for someone installing backuppc, which obviously needs a lot of storage to be useful, generously added dependencies wouldn't be problematic.

Anyway, I'll see to updating this to current upstream

@dedeckeh dedeckeh added the core packages pull request/issue for core (in-tree) packages label Apr 10, 2018
@ghost
Copy link
Author

ghost commented Apr 12, 2018

Hm. It seems, the newest version needs (or at least would like to have) libcap and libidn. These are in openwrt/packages. Can I depend on those or would that mean to either move libcap and libidn to openwrt/openwrt or to move iputils to openwrt/packages?

@diizzyy
Copy link
Contributor

diizzyy commented Jul 18, 2018

If you need external packages I'd suggest that you move it to the packages repo instead. Also please update to a more recent version. https://github.com/iputils/iputils

@ynezz
Copy link
Member

ynezz commented Dec 3, 2018

@nonicknamewasleftforme You should use $(INSTALL_SUID), if you're fixing some of the utils, what about the others like arping etc.? Could you please provide fix for complete package? Once done, please ping me back, I'll test it.

@jow-
Copy link
Contributor

jow- commented Jan 22, 2019

Pulled into my staging tree at https://git.openwrt.org/openwrt/staging/jow.git

@jow- jow- closed this Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core packages pull request/issue for core (in-tree) packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants