prometheus-node-exporter-lua: hostad ubus stats

[PolynomialDivision]

There is already the hostapd_stations exporter, which uses hostapd-utils (more precisely hostapd-cli) to get client statistics. However, the ubus interface is permanently integrated under hostapd in OpenWrt. So this exporter needs one dependency less.

For now it exports mainly the rrm statistics. Many people are interested in what your device supports. The exporter provides information about the radio-resource-managment extensions.

Maintainer: @champtar
Compile tested: (put here arch, model, OpenWrt version)
Run tested: r14549+2-036221ce5a89

[PolynomialDivision]

Ah wait. There is to much code.

[PolynomialDivision]

Merge? ;)

[champtar]

Do you want to look at lua bitop first ?
#9707 (comment)

[karlp]

Do you want to look at lua bitop first ?
#9707 (comment)

It should be s/bit32/bit/g and.... done. You can even keep calling the local bit32 and just change the require to

local bit32 = require "bit"

and you should be good to go.

[PolynomialDivision]

Wait. Run-testing gives me
Sat Oct 10 12:45:14 2020 daemon.info procd: Instance prometheus-node-exporter-lua::instance1 pid 6134 not stopped on SIGTERM, sending SIGKILL instead

[PolynomialDivision]

If I remove my plugin, it will have that SIGKILL issue, too. So this is a bug that is not caused by my plugin. So merge. ;)

[neheb]

     utils/prometheus-node-exporter-lua/files/usr/lib/lua/prometheus-collectors/hostapd_ubus_stations.lua:9:7: unused loop variable dev
    utils/prometheus-node-exporter-lua/files/usr/lib/lua/prometheus-collectors/hostapd_ubus_stations.lua:19:65: accessing undefined variable metric
    utils/prometheus-node-exporter-lua/files/usr/lib/lua/prometheus-collectors/hostapd_ubus_stations.lua:19:121: line is too long (129 > 120)
    utils/prometheus-node-exporter-lua/files/usr/lib/lua/prometheus-collectors/hostapd_ubus_stations.lua:20:64: accessing undefined variable metric
    utils/prometheus-node-exporter-lua/files/usr/lib/lua/prometheus-collectors/hostapd_ubus_stations.lua:20:121: line is too long (127 > 120)
    utils/prometheus-node-exporter-lua/files/usr/lib/lua/prometheus-collectors/hostapd_ubus_stations.lua:21:70: accessing undefined variable metric
    utils/prometheus-node-exporter-lua/files/usr/lib/lua/prometheus-collectors/hostapd_ubus_stations.lua:21:121: line is too long (139 > 120)
    utils/prometheus-node-exporter-lua/files/usr/lib/lua/prometheus-collectors/hostapd_ubus_stations.lua:22:69: accessing undefined variable metric
    utils/prometheus-node-exporter-lua/files/usr/lib/lua/prometheus-collectors/hostapd_ubus_stations.lua:22:121: line is too long (137 > 120)
    utils/prometheus-node-exporter-lua/files/usr/lib/lua/prometheus-collectors/hostapd_ubus_stations.lua:23:68: accessing undefined variable metric
    utils/prometheus-node-exporter-lua/files/usr/lib/lua/prometheus-collectors/hostapd_ubus_stations.lua:23:121: line is too long (135 > 120)
    utils/prometheus-node-exporter-lua/files/usr/lib/lua/prometheus-collectors/hostapd_ubus_stations.lua:24:64: accessing undefined variable metric
    utils/prometheus-node-exporter-lua/files/usr/lib/lua/prometheus-collectors/hostapd_ubus_stations.lua:24:121: line is too long (127 > 120)
    utils/prometheus-node-exporter-lua/files/usr/lib/lua/prometheus-collectors/hostapd_ubus_stations.lua:25:65: accessing undefined variable metric
    utils/prometheus-node-exporter-lua/files/usr/lib/lua/prometheus-collectors/hostapd_ubus_stations.lua:25:121: line is too long (129 > 120)
    utils/prometheus-node-exporter-lua/files/usr/lib/lua/prometheus-collectors/hostapd_ubus_stations.lua:26:1: line contains only whitespace
    utils/prometheus-node-exporter-lua/files/usr/lib/lua/prometheus-collectors/hostapd_ubus_stations.lua:54:1: line contains only whitespace

edit: aside from the metric stuff, the other warnings seem legit.

[karlp]

The warnings are not legitmate, as they're making assumptions that this is a internal project that should be bound by internal style guidelines. It's purely an implementation detail that this package has the code within the package. Style of this package should be completely in the hands of the package maintainers.

[champtar]

@neheb is there a warning level instead of pass or fail for the linter ?

[neheb]

That's a question for @aparcar . I've suggested an allow to fail option for the linter.

[PolynomialDivision]

edit: aside from the metric stuff, the other warnings seem legit.

Whups. Sry. I thought this would only be the metric warning. I will reduce line size. I have to learn to read more carefully. ;)

[PolynomialDivision]

@neheb Fixed the lint warnings. ;) Merge?

[aparcar]

LGTM

[PolynomialDivision]

Do you want to look at lua bitop first ?
#9707 (comment)

It should be s/bit32/bit/g and.... done. You can even keep calling the local bit32 and just change the require to

local bit32 = require "bit"

and you should be good to go.

I thought I did this. :/
Installed the exporter on a clean system again and the lib was missing... Then I saw I forgot to change exactly that line.
#13807