-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samplicator: update to latest master commit 2022-10-11 #19570
Merged
PolynomialDivision
merged 1 commit into
openwrt:master
from
PolynomialDivision:update-samplicator
Oct 27, 2022
Merged
samplicator: update to latest master commit 2022-10-11 #19570
PolynomialDivision
merged 1 commit into
openwrt:master
from
PolynomialDivision:update-samplicator
Oct 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
516d4b3
to
3acdc2d
Compare
3acdc2d
to
68c8873
Compare
BKPepe
requested changes
Oct 9, 2022
68c8873
to
ff000dd
Compare
BKPepe
reviewed
Oct 9, 2022
fad1009
to
9417e28
Compare
ping @BKPepe ;) Is that now fine? this change is very important. |
Its not. It can wait. No need to ping me after a day. Its master branch,
not stable ones. I'll get to it later. In the meantime, you can check yours
other pendings pull requests.
I'd say that security issues are important, not ordinary package bump.
Dne po 10. 10. 2022 9:01 uživatel Nick Hainke ***@***.***>
napsal:
… ping @BKPepe <https://github.com/BKPepe> ;) Is that now fine? this change
is very important.
—
Reply to this email directly, view it on GitHub
<#19570 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7IDVELZIRFT5WKJ6RYUXLWCO5MHANCNFSM6AAAAAARAWI66A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I am still interested whats wrong. :P |
@BKPepe Do you have time telling me whats still wrong? |
BKPepe
reviewed
Oct 27, 2022
The newest master branch has important fixes. However, no new release is published [0]. Switch to git and update to latest master commit. This introduces new version scheme by using YYYY-MM-DD of the commit. In addition, add necessary "PKG_FIXUP" and "PKG_REMOVE_FILES" to allow compile the new version. Also add enable "PKG_BUILD_PARALLEL". Further, use a pidfile and remove outdated patches. sleinen/samplicator#73 Signed-off-by: Nick Hainke <[email protected]>
9417e28
to
c43b54b
Compare
Once, the CI pass, feel free to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: me
Compile tested: belkin rt3200
Run tested: belkin rt3200