Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openwrt-22.03] stubby: actually switch to ca-bundle and update to 0.4.3 #20235

Closed
wants to merge 2 commits into from
Closed

Conversation

ghost
Copy link

@ghost ghost commented Jan 7, 2023

Fixes commit 11731c8.

Also updates stubby to 0.4.3. See the changelog from upstream for more details about the update.

Aquila Cooper added 2 commits January 7, 2023 05:12
Fixes commit 11731c8.

Signed-off-by: Aquila Cooper <[email protected]>
Changelog from upstream (https://github.com/getdnsapi/stubby/blob/v0.4.3/ChangeLog):

* 2022-12-22: version 0.4.3
  * Fix Issue getdnsapi/stubby#330 and PR getdnsapi/stubby#324: PrivateUsers=false needed in systemd
    stubby.service file for stubby to start.
    Thanks Archcan and Petr Menšík
  * PR getdnsapi/stubby#323: Reduce log messages when interface is offline.
    Thanks Russ Bubley and Andre Heider 

* 2022-08-19: version 0.4.2
  * Fix Issue getdnsapi/stubby#320: Stubby doesn't start without "log_level"
    entry. Thanks Johnny S. Lee

* 2022-08-19: Version 0.4.1
  * Several updates to the servers in the config file:
     * sinodun.dnsovertls*.com servers are removed and will be
       decommissioned in the near future. This leaves only the
       getdnsapi.net server as the default.
       A recommendation is made that users choose additional servers
       from the list available.
     * Additional Quad9 servers added (thanks pataquets).
     * LDN servers removed as the service is now stopped. 
     * Tidy up of remaining server data.
     * Change `comment` lines on Uncensored server data to more clearly
       be comments (not valid YAML)
     * Fix and improve descriptions of default values
     * getdnsapi.net DoT servers liston on port 443 now too
  * Fixes for parsing of quoted key values for `tls-ca-file`,
    `tls-curves-list` and `resolvconf`
  * Add Dockerfile into `contrib` - thanks to pataquets.
  * Strengthen version checking for LibIDN2 during the cmake step so
    LibIDN2 version 2.3.3 can be properly found (thanks jpbion).
  * Updated stubby.service file. Thanks Bruno Pagani
  * log level configurable in config file with log_level setting
    Command line setting (with -v or -l) overrules the config file
    setting

Signed-off-by: Aquila Cooper <[email protected]>
@ghost ghost changed the title [openwrt-22.03] stubby: actually switch to ca-bundle [openwrt-22.03] stubby: actually switch to ca-bundle and update to 0.4.3 Jan 7, 2023
@hnyman hnyman added the OpenWrt 22.03 Issue/PR on branch 22.03 label Jan 7, 2023
@hnyman
Copy link
Contributor

hnyman commented Jan 7, 2023

Regarding the dependency change:

Fixes commit 11731c8

As discussed in the PR #10745 about that commit, the "ca-certs" is meant as a flexible alternative that enables the user to use either ca-certificates or ca-bundle, as some other package might explicitly require one of them and you shouldn't be forced to install both if not necessary. So, stubby accepts either of them.

The flexibility is provided by openwrt/openwrt@dd29980

You proposal would force to use ca-bundle.

NAK from me regarding that aspect.

@ghost
Copy link
Author

ghost commented Jan 7, 2023

Ah, my bad, then. I was unaware of that discussion. I'll close this PR and create another one to only update stubby.

@ghost ghost closed this Jan 7, 2023
@ghost ghost deleted the patch-3 branch January 7, 2023 10:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OpenWrt 22.03 Issue/PR on branch 22.03 work needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant