-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
netbird: Update to 0.33.0 #25425
netbird: Update to 0.33.0 #25425
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Maycon,
Requested changes for the new version, also change the commit and PR title to netbird: update to 0.33.0
.
I am planning to test the changes as soon as possible, because of the recent changes from opkg
to apk
, my automated build and environment need adjustment.
Thanks, @wehagy. I've committed to your suggestions and updated the title. I might also be able to test on Raspberry Pi 5 tomorrow. |
You need to squash the 3 commits together to just 1 commit. And @oskarirauta is mentioned in Makefile as maintainer, but as other have been more active lately, either @wehagy or @mlsmaycon might be mentioned there instead? |
And change commit prefix title to
I can open a PR putting myself as a maintainer, to be honest, I haven't done this yet because I am not familiar with the GO language or OpenWrt codebase. Compile and run tested
VersionAdditional information
My repo with my automated build can be see here: And my artifacts here: Tested-by: Wesley Gimenes [email protected] |
@wehagy I've made the changes, but since you did the test I will be more than happy to close this one and wait for your PR. |
changelog: https://github.com/netbirdio/netbird/releases/tag/v0.33.0 supersedes: openwrt#25425 Signed-off-by: Wesley Gimenes <[email protected]>
I don't like to interfere with others PR's, I appreciate your contribution. However, since you've given your permission, you can close this PR. I've opened the PR below to replace the existing one and update
|
Sounds good, thanks. |
Maintainer: me / @wehagy
Compile tested: TODO
Run tested: TODO
Description: update NetBird package version to 0.32.0