Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netbird: Update to 0.33.0 #25425

Closed
wants to merge 1 commit into from
Closed

Conversation

mlsmaycon
Copy link

@mlsmaycon mlsmaycon commented Nov 22, 2024

Maintainer: me / @wehagy
Compile tested: TODO
Run tested: TODO

Description: update NetBird package version to 0.32.0

@mlsmaycon mlsmaycon marked this pull request as draft November 22, 2024 15:14
Copy link
Contributor

@wehagy wehagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Maycon,

Requested changes for the new version, also change the commit and PR title to netbird: update to 0.33.0.

I am planning to test the changes as soon as possible, because of the recent changes from opkg to apk, my automated build and environment need adjustment.

net/netbird/Makefile Outdated Show resolved Hide resolved
net/netbird/Makefile Outdated Show resolved Hide resolved
@mlsmaycon mlsmaycon changed the title Update NetBird to 0.32.0 NetBird: Update to 0.33.0 Nov 24, 2024
@mlsmaycon
Copy link
Author

Thanks, @wehagy. I've committed to your suggestions and updated the title. I might also be able to test on Raspberry Pi 5 tomorrow.

@hnyman
Copy link
Contributor

hnyman commented Nov 24, 2024

You need to squash the 3 commits together to just 1 commit.

And @oskarirauta is mentioned in Makefile as maintainer, but as other have been more active lately, either @wehagy or @mlsmaycon might be mentioned there instead?

@wehagy
Copy link
Contributor

wehagy commented Dec 1, 2024

You need to squash the 3 commits together to just 1 commit.

And change commit prefix title to netbird: to make CI happy.

And @oskarirauta is mentioned in Makefile as maintainer, but as other have been more active lately, either @wehagy or @mlsmaycon might be mentioned there instead?

I can open a PR putting myself as a maintainer, to be honest, I haven't done this yet because I am not familiar with the GO language or OpenWrt codebase.

Compile and run tested

Package architecture Target Subtarget Brand Model Hardware Version OpenWrt version
x86_64 x86 64 Duex DX B75ZG M.2 Intel LGA 1155 DDR3 n/a OpenWrt SNAPSHOT r28146-52b6c92479

Version

Additional information

x86_64 running as container with incus.
Compiled package with container sdk, and build openwrt image with container imagebuilder.

My repo with my automated build can be see here:

And my artifacts here:

Tested-by: Wesley Gimenes [email protected]

@mlsmaycon mlsmaycon changed the title NetBird: Update to 0.33.0 netbird: Update to 0.33.0 Dec 2, 2024
@mlsmaycon
Copy link
Author

@wehagy I've made the changes, but since you did the test I will be more than happy to close this one and wait for your PR.

wehagy added a commit to wehagy/packages that referenced this pull request Dec 5, 2024
@wehagy
Copy link
Contributor

wehagy commented Dec 5, 2024

@wehagy I've made the changes, but since you did the test I will be more than happy to close this one and wait for your PR.

I don't like to interfere with others PR's, I appreciate your contribution. However, since you've given your permission, you can close this PR. I've opened the PR below to replace the existing one and update netbird to version 0.34.0.

@mlsmaycon
Copy link
Author

@wehagy I've made the changes, but since you did the test I will be more than happy to close this one and wait for your PR.

I don't like to interfere with others PR's, I appreciate your contribution. However, since you've given your permission, you can close this PR. I've opened the PR below to replace the existing one and update netbird to version 0.34.0.

Sounds good, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants