siproxd: improve network device resolution #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve network devices by first trying 'network_get_device' (L3) and falling back to 'network_get_physdev' (L2) on failure, which allows using Wireguard interfaces. Both are needed to avoid breaking existing usage for some interfaces (e.g. 'wan'). Also add myself as a maintainer. Signed-off-by: Tony Ambardar <[email protected]>
|
Hi Tony (@guidosarducci), I accept your changes. Thank you! Kind regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: @micmac1 @jslachta
Description:
Resolve network devices by first trying
network_get_device(L3) and falling back tonetwork_get_physdev(L2) on failure, which allows using Wireguard interfaces. Both are needed to avoid breaking existing usage for some interfaces (e.g.wan).Also add myself as a maintainer.
This might help or fix #800, but I can't reproduce the error myself and don't have a VOIP-over-Wireguard setup at hand.
Testing:
Compile tested for ipq40xx, targeting EA6350v3 device on master.
Run tested on EA6350v3 with 23.05.2.
Checked problems with
network_get_deviceandnetwork_get_physdevfrom CLI, and confirmed siproxd config file/var/etc/siproxd/siproxd-general.confcontains correctwginterface after startup with this change.