Split RunAndCompare with reference backend functionality into a mixin.
#21150
+323
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_713316671
branch
2 times, most recently
from
dd97e16 to
3204cd9
Compare
Many users don't require `RunAndCompare` functionality, but are forced to select and initialize a reference backend anyway. With this change, users can opt to extend their specific `HloRunnerAgnosticTestBase` implementation to add `RunAndCompare` functionality. The mixin acts as a wrapper around any `HloRunnerAgnosticTestBase` implementation, allowing a high degree of customization. PiperOrigin-RevId: 714085396
copybara-service
bot
force-pushed
the
test_713316671
branch
from
3204cd9 to
08dcaad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split
RunAndComparewith reference backend functionality into a mixin.Many users don't require
RunAndComparefunctionality, but are forced to selectand initialize a reference backend anyway.
With this change, users can opt to extend their specific
HloRunnerAgnosticTestBaseimplementation to addRunAndComparefunctionality.The mixin acts as a wrapper around any
HloRunnerAgnosticTestBaseimplementation, allowing a high degree of customization.