PR #19066: [XLA:CPU][oneDNN] Handle oneDNN scalar #21155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_713373780
branch
3 times, most recently
from
f6f5948 to
c5e3657
Compare
Imported from GitHub PR #19066 This PR makes sure oneDNN handles the scalar properly. Copybara import of the project: -- 2fb157a by Mahmoud Abuzaina <[email protected]>: Handle oneDNN scalar -- 77a39b6 by Mahmoud Abuzaina <[email protected]>: Addressed review comments -- 32b5aba by Mahmoud Abuzaina <[email protected]>: Return output instead of having parameter -- 576e244 by Mahmoud Abuzaina <[email protected]>: Unpack the pair return Merging this change closes #19066 COPYBARA_INTEGRATE_REVIEW=#19066 from Intel-tensorflow:mabuzain/handle-onednn-scalar 576e244 PiperOrigin-RevId: 714289598
copybara-service
bot
force-pushed
the
test_713373780
branch
from
c5e3657 to
724919f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #19066: [XLA:CPU][oneDNN] Handle oneDNN scalar
Imported from GitHub PR #19066
This PR makes sure oneDNN handles the scalar properly.
Copybara import of the project:
--
2fb157a by Mahmoud Abuzaina [email protected]:
Handle oneDNN scalar
--
77a39b6 by Mahmoud Abuzaina [email protected]:
Addressed review comments
--
32b5aba by Mahmoud Abuzaina [email protected]:
Return output instead of having parameter
--
576e244 by Mahmoud Abuzaina [email protected]:
Unpack the pair return
Merging this change closes #19066
FUTURE_COPYBARA_INTEGRATE_REVIEW=#19066 from Intel-tensorflow:mabuzain/handle-onednn-scalar 576e244