Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nfc] Cleanup build files for expander transforms #21223

Closed
wants to merge 1 commit into from
Closed

[nfc] Cleanup build files for expander transforms #21223

wants to merge 1 commit into from

Conversation

shraiysh
Copy link
Contributor

@shraiysh shraiysh commented Jan 9, 2025

This is part-3 of #18785 and #20595.

Motivation: Smaller build files, fewer merge conflicts, and convinience in development (more intuitive targets). For discussion surrounding this, check thread in #18785.

@shraiysh shraiysh self-assigned this Jan 9, 2025
@shraiysh shraiysh added the kokoro:force-run Forces CI to rerun label Jan 9, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Forces CI to rerun label Jan 9, 2025
akuegel
akuegel approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@akuegel akuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
I will also check whether some internal dependencies need to be adjusted and take care of them.

@akuegel
Copy link
Member

akuegel commented Jan 13, 2025

@shraiysh it seems there are now some merge conflicts, can you please rebase?

@shraiysh shraiysh force-pushed the cleanup_expander_transforms branch from 4fa92d8 to 7832f84 Compare January 13, 2025 18:30
@shraiysh shraiysh added the kokoro:force-run Forces CI to rerun label Jan 13, 2025
@shraiysh shraiysh requested a review from akuegel January 13, 2025 18:30
@shraiysh
Copy link
Contributor Author

@shraiysh it seems there are now some merge conflicts, can you please rebase?

Done. Thanks for the review!

@kokoro-team kokoro-team removed the kokoro:force-run Forces CI to rerun label Jan 13, 2025
@shraiysh
[nfc] Cleanup build files for expander transforms
7832f84 
This is part-3 of openxla#18785 and openxla#20595.

Motivation: Smaller build files, fewer merge conflicts, and convinience
in development (more intuitive targets). For discussion surrounding
this, check thread in openxla#18785.
copybara-service bot pushed a commit that referenced this pull request Jan 13, 2025
@shraiysh @Google-ML-Automation
PR #21223: [nfc] Cleanup build files for expander transforms
eb0b636 
Imported from GitHub PR #21223

This is part-3 of #18785 and #20595.

Motivation: Smaller build files, fewer merge conflicts, and convinience in development (more intuitive targets). For discussion surrounding this, check thread in #18785.
Copybara import of the project:

--
7832f84 by Shraiysh Vaishay <[email protected]>:

[nfc] Cleanup build files for expander transforms

This is part-3 of #18785 and #20595.

Motivation: Smaller build files, fewer merge conflicts, and convinience
in development (more intuitive targets). For discussion surrounding
this, check thread in #18785.

Merging this change closes #21223

FUTURE_COPYBARA_INTEGRATE_REVIEW=#21223 from shraiysh:cleanup_expander_transforms 7832f84
PiperOrigin-RevId: 715055989
@copybara-service copybara-service bot mentioned this pull request Jan 13, 2025
Merged
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Jan 13, 2025
@shraiysh @tensorflower-gardener
PR #21223: [nfc] Cleanup build files for expander transforms
d4957ed 
Imported from GitHub PR openxla/xla#21223

This is part-3 of #18785 and #20595.

Motivation: Smaller build files, fewer merge conflicts, and convinience in development (more intuitive targets). For discussion surrounding this, check thread in #18785.
Copybara import of the project:

--
7832f8483091b70214d17789c05c38959d67a515 by Shraiysh Vaishay <[email protected]>:

[nfc] Cleanup build files for expander transforms

This is part-3 of #18785 and #20595.

Motivation: Smaller build files, fewer merge conflicts, and convinience
in development (more intuitive targets). For discussion surrounding
this, check thread in #18785.

Merging this change closes #21223

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#21223 from shraiysh:cleanup_expander_transforms 7832f8483091b70214d17789c05c38959d67a515
PiperOrigin-RevId: 715055989
@copybara-service copybara-service bot mentioned this pull request Jan 13, 2025
Merged
@shraiysh
Copy link
Contributor Author

This has conflicts again, should I fix them, or is it already in the process of merging @akuegel ? Is it okay to push commits on this now, or will that break some workflows?

@akuegel
Copy link
Member

akuegel commented Jan 14, 2025

This has conflicts again, should I fix them, or is it already in the process of merging @akuegel ? Is it okay to push commits on this now, or will that break some workflows?

It is already in the process of merging. I will take care of rebasing.

@shraiysh
Copy link
Contributor Author

Thanks!

copybara-service bot pushed a commit that referenced this pull request Jan 14, 2025
@shraiysh @Google-ML-Automation
PR #21223: [nfc] Cleanup build files for expander transforms
0ed1754 
Imported from GitHub PR #21223

This is part-3 of #18785 and #20595.

Motivation: Smaller build files, fewer merge conflicts, and convinience in development (more intuitive targets). For discussion surrounding this, check thread in #18785.
Copybara import of the project:

--
7832f84 by Shraiysh Vaishay <[email protected]>:

[nfc] Cleanup build files for expander transforms

This is part-3 of #18785 and #20595.

Motivation: Smaller build files, fewer merge conflicts, and convinience
in development (more intuitive targets). For discussion surrounding
this, check thread in #18785.

Merging this change closes #21223

FUTURE_COPYBARA_INTEGRATE_REVIEW=#21223 from shraiysh:cleanup_expander_transforms 7832f84
PiperOrigin-RevId: 715055989
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Jan 14, 2025
@shraiysh @tensorflower-gardener
PR #21223: [nfc] Cleanup build files for expander transforms
3593e59 
Imported from GitHub PR openxla/xla#21223

This is part-3 of #18785 and #20595.

Motivation: Smaller build files, fewer merge conflicts, and convinience in development (more intuitive targets). For discussion surrounding this, check thread in #18785.
Copybara import of the project:

--
7832f8483091b70214d17789c05c38959d67a515 by Shraiysh Vaishay <[email protected]>:

[nfc] Cleanup build files for expander transforms

This is part-3 of #18785 and #20595.

Motivation: Smaller build files, fewer merge conflicts, and convinience
in development (more intuitive targets). For discussion surrounding
this, check thread in #18785.

Merging this change closes #21223

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#21223 from shraiysh:cleanup_expander_transforms 7832f8483091b70214d17789c05c38959d67a515
PiperOrigin-RevId: 715055989
copybara-service bot pushed a commit that referenced this pull request Jan 14, 2025
@shraiysh @Google-ML-Automation
PR #21223: [nfc] Cleanup build files for expander transforms
9faaa8e 
Imported from GitHub PR #21223

This is part-3 of #18785 and #20595.

Motivation: Smaller build files, fewer merge conflicts, and convinience in development (more intuitive targets). For discussion surrounding this, check thread in #18785.
Copybara import of the project:

--
7832f84 by Shraiysh Vaishay <[email protected]>:

[nfc] Cleanup build files for expander transforms

This is part-3 of #18785 and #20595.

Motivation: Smaller build files, fewer merge conflicts, and convinience
in development (more intuitive targets). For discussion surrounding
this, check thread in #18785.

Merging this change closes #21223

FUTURE_COPYBARA_INTEGRATE_REVIEW=#21223 from shraiysh:cleanup_expander_transforms 7832f84
PiperOrigin-RevId: 715055989
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Jan 14, 2025
@tensorflower-gardener
Automated Code Change
f3b0cb6 
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#21223 from shraiysh:cleanup_expander_transforms 7832f8483091b70214d17789c05c38959d67a515
PiperOrigin-RevId: 714919160
@copybara-service copybara-service bot mentioned this pull request Jan 14, 2025
Merged
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Jan 14, 2025
@tensorflower-gardener
Automated Code Change
c9974b4 
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#21223 from shraiysh:cleanup_expander_transforms 7832f8483091b70214d17789c05c38959d67a515
PiperOrigin-RevId: 715163205
@copybara-service copybara-service bot mentioned this pull request Jan 14, 2025
Draft
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Jan 14, 2025
@shraiysh @tensorflower-gardener
PR #21223: [nfc] Cleanup build files for expander transforms
54b414f 
Imported from GitHub PR openxla/xla#21223

This is part-3 of #18785 and #20595.

Motivation: Smaller build files, fewer merge conflicts, and convinience in development (more intuitive targets). For discussion surrounding this, check thread in #18785.
Copybara import of the project:

--
7832f8483091b70214d17789c05c38959d67a515 by Shraiysh Vaishay <[email protected]>:

[nfc] Cleanup build files for expander transforms

This is part-3 of #18785 and #20595.

Motivation: Smaller build files, fewer merge conflicts, and convinience
in development (more intuitive targets). For discussion surrounding
this, check thread in #18785.

Merging this change closes #21223

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#21223 from shraiysh:cleanup_expander_transforms 7832f8483091b70214d17789c05c38959d67a515
PiperOrigin-RevId: 715265588
@copybara-service copybara-service bot mentioned this pull request Jan 14, 2025
Draft
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Jan 14, 2025
@shraiysh @tensorflower-gardener
PR #21223: [nfc] Cleanup build files for expander transforms
946a302 
Imported from GitHub PR openxla/xla#21223

This is part-3 of #18785 and #20595.

Motivation: Smaller build files, fewer merge conflicts, and convinience in development (more intuitive targets). For discussion surrounding this, check thread in #18785.
Copybara import of the project:

--
7832f8483091b70214d17789c05c38959d67a515 by Shraiysh Vaishay <[email protected]>:

[nfc] Cleanup build files for expander transforms

This is part-3 of #18785 and #20595.

Motivation: Smaller build files, fewer merge conflicts, and convinience
in development (more intuitive targets). For discussion surrounding
this, check thread in #18785.

Merging this change closes #21223

PiperOrigin-RevId: 715263765
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akuegel akuegel akuegel approved these changes

@xla-rotation xla-rotation Awaiting requested review from xla-rotation

Assignees

@shraiysh shraiysh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shraiysh @akuegel @kokoro-team