This repository has been archived by the owner on Apr 14, 2018. It is now read-only.
Bunch of merge + logging and refactoring #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a timeout to the wait_for_beacon() function (30 seconds) after
which the USB device is reset and the process starts again.
* Send a 'sleep' command to the tracker after a successful sync, based
on the way the Windows software behaves.
* Various changes to the main client function:
+ Write a brief log file to keep an eye on the status easily
(/var/log/fitbit.log)
+ Make stdout line buffered for running under supervise/multilog for
example.
+ Don't sleep for 15 minutes each time - since we now send a sleep
command for the tracker it should make sense for the client program
to listen for beacons all the time.
with object creation/destruction. Also had to split some logic out of the main/run function into try_sync, to avoid storing a reference to the FitBitClient object in the stack frame of main/run when an exception is thrown.
and loop forever until it succeeds.
has its own timeout.
Also fix what seems like a logic error in a condition.
added 7 commits
July 9, 2012 22:22
added 20 commits
August 14, 2012 09:33
--HG-- rename : python/antprotocol/bases.py => python/antprotocol/connection.py
|
This looks like a great improvement. Is there a reason it is not being pulled? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked at the network and merged what I found interesting, based on the result, I tried to make the fitbit_client easier to read. This is the result.
This is more a 'look at what I did' than an actual pull-request, as I can understand that this one contains way to much to be reviewable ... Anyway, feel free to pull as you like.
Thanks for the base you wrote !