Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds german translations. #58

Merged
merged 3 commits into from
Jun 29, 2018
Merged

Adds german translations. #58

merged 3 commits into from
Jun 29, 2018

Conversation

AVGP
Copy link
Contributor

@AVGP AVGP commented Jun 29, 2018

refs #56

@kelson42
Copy link
Contributor

@AVGP Thx for the PR!

@dattaz
Copy link
Collaborator

dattaz commented Jun 29, 2018

Hello,
Thanks a lot for you PR !
Can you add initialization for german please ? (see https://github.com/openzim/gutenberg/blob/master/gutenbergtozim/templates/l10n/locales.ini and also here https://github.com/openzim/gutenberg/blob/master/gutenbergtozim/export.py#L40 )

@AVGP
Copy link
Contributor Author

AVGP commented Jun 29, 2018

@dattaz done :shipit:

@dattaz dattaz merged commit 6ff3d25 into openzim:master Jun 29, 2018
@dattaz
Copy link
Collaborator

dattaz commented Jun 29, 2018

Thanks 👍 🎆

@dattaz
Copy link
Collaborator

dattaz commented Jul 4, 2018

@AVGP Hi, we found with your PR that we have 2 system for translations, I am unifying them, but i'm missing some german strings, can you give me them by comment here ? Thanks.

"Interface language" : (https://github.com/openzim/gutenberg/blob/master/gutenbergtozim/l10n.py#L26)
"List books of a single Author" : ( https://github.com/openzim/gutenberg/blob/master/gutenbergtozim/l10n.py#L33 )
"Choose the Catalog" : ( https://github.com/openzim/gutenberg/blob/master/gutenbergtozim/l10n.py#L79 )
"Main languages" : ( https://github.com/openzim/gutenberg/blob/master/gutenbergtozim/l10n.py#L82 )
"Other languages" : ( https://github.com/openzim/gutenberg/blob/master/gutenbergtozim/l10n.py#L85 )

@kelson42
Copy link
Contributor

kelson42 commented Sep 4, 2018

@dattaz done c663232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants