Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #122

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Upgrade dependencies #122

merged 3 commits into from
Dec 16, 2024

Conversation

benoit74
Copy link
Contributor

@benoit74 benoit74 commented Dec 16, 2024

Fix #36

See list of commits for changes.

Node 22 is the new LTS

Python 3.13 is still not used because we are waiting for zimscraperlib upgrade.

@benoit74 benoit74 self-assigned this Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.39%. Comparing base (e74d4a8) to head (e2cce21).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #122   +/-   ##
=======================================
  Coverage   51.39%   51.39%           
=======================================
  Files          20       20           
  Lines        1185     1185           
  Branches      163      135   -28     
=======================================
  Hits          609      609           
  Misses        564      564           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 marked this pull request as ready for review December 16, 2024 09:08
@benoit74 benoit74 requested a review from rgaudin December 16, 2024 09:08
@benoit74
Copy link
Contributor Author

See #119 (comment) for failure reason

@benoit74 benoit74 merged commit e33d18e into main Dec 16, 2024
9 of 10 checks passed
@benoit74 benoit74 deleted the upgrade_deps branch December 16, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade/cleanup dependencies before release
2 participants