Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pages to the ZIM and display them in the UI #28

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Conversation

benoit74
Copy link
Contributor

@benoit74 benoit74 commented Oct 4, 2024

Fix #7

Changes:

  • fetch page content, store in the ZIM, display it
  • remove home.json which is not needed anymore, home is just a normal page indeed
  • added root page path to shared.json
  • added summary page data to shared.json so that we can transform nice looking paths into page id and title
  • modified integration test to fetch only a small subtree of the whole website inside the ZIM for quick execution

@benoit74 benoit74 self-assigned this Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 44.82759% with 16 lines in your changes missing coverage. Please review.

Project coverage is 47.22%. Comparing base (18d81f3) to head (c3b6266).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/libretexts2zim/client.py 28.57% 10 Missing ⚠️
scraper/src/libretexts2zim/processor.py 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   47.54%   47.22%   -0.33%     
==========================================
  Files           7        7              
  Lines         408      432      +24     
  Branches       40       45       +5     
==========================================
+ Hits          194      204      +10     
- Misses        212      226      +14     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 force-pushed the add_pages_to_zim branch 2 times, most recently from b8393df to 832e7cb Compare October 4, 2024 18:58
@benoit74 benoit74 marked this pull request as ready for review October 7, 2024 08:03
@benoit74 benoit74 requested a review from rgaudin October 7, 2024 08:03
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zimui/src/stores/main.ts Outdated Show resolved Hide resolved
zimui/src/stores/main.ts Outdated Show resolved Hide resolved
@benoit74
Copy link
Contributor Author

benoit74 commented Oct 8, 2024

Thank you, still not used to this notation, I keep forgetting about it!

@benoit74 benoit74 merged commit 733c35a into main Oct 8, 2024
10 checks passed
@benoit74 benoit74 deleted the add_pages_to_zim branch October 8, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display page content in the ZIM UI
2 participants