-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API and caching #4
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
===========================================
- Coverage 56.72% 44.94% -11.79%
===========================================
Files 7 7
Lines 238 336 +98
Branches 19 32 +13
===========================================
+ Hits 135 151 +16
- Misses 102 184 +82
Partials 1 1 ☔ View full report in Codecov by Sentry. |
a04e45e
to
9a30ccc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find we're duplicating the cache reading/writing bits ; maybe room for sharing this
49e1090
to
e86c6c8
Compare
This is probably because some of the code was buggy ^^ I fixed this. There is indeed only small variations ... but pretty important ones. |
52ac5cf
to
2def419
Compare
a71de74
to
a3cd390
Compare
2def419
to
c3bb8c5
Compare
I had to rebase to fix conflicts. Please review only two last commits which contains "real" modifications. Nota: Iast commit is about making codecov informational. I find it's mostly mandatory since in scrapers like this one, most code is covered by integration tests, but these are not reported in codecov ... |
…tion tests, not considered by Codecov
2edf93b
to
40cb342
Compare
Changes:
Nota: this is not yet used to populate anything in the ZIM, only "utility" code for now
To be reviewed after #3 is merged