Fix lint

openzim · Dec 4, 2024 · 0bc7f1b · 0bc7f1b
1 parent 7b4312e
commit 0bc7f1b
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 5 deletions.
diff --git a/src/renderers/abstract.renderer.ts b/src/renderers/abstract.renderer.ts
@@ -689,11 +689,12 @@ export abstract class Renderer {
    * Because of CSP, some ZIM reader environments do not allow inline JS. Create a new JS script by combining
    * all of the inline scripts. Not sure if the JS will still work, but it's better than just deleting it. See
    * https://github.com/openzim/mwoffliner/issues/2096
+   *
    * @param parsoidDoc
    */
   private collectInlineJsImpl(parsoidDoc: DominoElement): string {
     const scripts = Array.from(parsoidDoc.getElementsByTagName('script')) as DominoElement[]
-    let collectedJs = []
+    const collectedJs = []
     for (const script of scripts) {
       if (script.innerHTML) {
         collectedJs.push(script.innerHTML)

diff --git a/src/renderers/wikimedia-mobile.renderer.ts b/src/renderers/wikimedia-mobile.renderer.ts
@@ -40,7 +40,6 @@ export class WikimediaMobileRenderer extends MobileRenderer {
         const moduleDependenciesFiltered = super.filterWikimediaMobileModules(_moduleDependencies)
         let mediaDependenciesVal
         let subtitlesVal
-        let inlineJsScriptTagVal
         const mobileHTML = domino.createDocument(data)
         const finalHTMLMobile = await this.pipeMobileTransformations(
           mobileHTML,

diff --git a/test/unit/renderers/abstract.renderer.test.ts b/test/unit/renderers/abstract.renderer.test.ts
@@ -3,7 +3,7 @@ import * as domino from 'domino'
 import { Renderer } from '../../../src/renderers/abstract.renderer'
 
 class ConcreteRenderer extends Renderer {
-  public async render(renderOpts: any): Promise<any> {
+  public async render(): Promise<any> {
     return Promise.resolve(null)
   }
 }

diff --git a/test/unit/saveArticles.test.ts b/test/unit/saveArticles.test.ts
@@ -12,7 +12,6 @@ import { VisualEditorRenderer } from '../../src/renderers/visual-editor.renderer
 import { WikimediaMobileRenderer } from '../../src/renderers/wikimedia-mobile.renderer.js'
 import { RestApiRenderer } from '../../src/renderers/rest-api.renderer.js'
 import { RENDERERS_LIST } from '../../src/util/const.js'
-import { MobileRenderer } from 'src/renderers/abstractMobile.render.js'
 
 jest.setTimeout(40000)
 
@@ -239,7 +238,6 @@ describe('saveArticles', () => {
 
       const articleDoc = domino.createDocument(result[0].html)
 
-      let foundInlineJsScript = false
       for (const scriptTag of Array.from(articleDoc.querySelectorAll('head > script'))) {
         if (scriptTag.textContent.includes('// Scripts taken')) {
           expect(scriptTag.textContent.includes('onBodyStart')).toBe(true)