Detect content type based on WARC-Resource-Type #306
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #296
Nota: this PR is slightly enhanced compared to what has been proposed in the issue due to some stuff that has been realized during implementation
Changes:
WARC-Resource-Type
header when available inside the WARC to decide what kind of content / rewrite we haveWARC-Resource-Type
is not guaranteed to be present inside the WARC, for old WARC but also for WARC created with other tools then Browsertrix crawler