Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle case where the redirect target is bad / unsupported #367

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Handle case where the redirect target is bad / unsupported #367

merged 1 commit into from
Jul 30, 2024

Conversation

benoit74
Copy link
Collaborator

Fix #356
Fix #332

Changes:

  • ignore errors when the redirect location is not a proper URL with a debug message
  • add two test cases to the test website and add them as integration tests

@benoit74 benoit74 force-pushed the bad_redirect_target branch from 2dcf5bd to be96eb7 Compare July 24, 2024 12:29
@benoit74 benoit74 changed the title Handle case where the redirect target is bad Handle case where the redirect target is bad / unsupported Jul 24, 2024
@benoit74 benoit74 force-pushed the bad_redirect_target branch from be96eb7 to 64988ca Compare July 24, 2024 12:32
@benoit74 benoit74 marked this pull request as ready for review July 24, 2024 12:32
@benoit74 benoit74 self-assigned this Jul 24, 2024
@benoit74 benoit74 requested a review from rgaudin July 24, 2024 12:32
@benoit74 benoit74 force-pushed the bad_redirect_target branch from 64988ca to 219d252 Compare July 26, 2024 05:08
rgaudin
rgaudin approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoit74 benoit74 merged commit b2deb60 into main Jul 30, 2024
5 checks passed
@benoit74 benoit74 deleted the bad_redirect_target branch July 30, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin rgaudin approved these changes

Assignees

@benoit74 benoit74

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@benoit74 @rgaudin