Use HTML/JS/CSS functions extracted in zimscraperlib and adapt to scraperlib 5 #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoit74
force-pushed
the
scraperlib_4_1
branch
from
e7eda21 to
36ee6f7
Compare
benoit74
changed the title
benoit74
force-pushed
the
scraperlib_4_1
branch
2 times, most recently
from
780a202 to
14b3a7e
Compare
benoit74
force-pushed
the
scraperlib_4_1
branch
2 times, most recently
from
ecfd573 to
e069c8b
Compare
rgaudin
approved these changes
Jan 7, 2025
…ere - and upgrade other dependencies
benoit74
force-pushed
the
scraperlib_4_1
branch
from
e069c8b to
1218df0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #411
Fix #421
All code and tests removed have been moved to zimscraperlib.
This PR also adds modifications linked to zimscraperlib 5 around metadata and i18n
This
iswas still WIP because Docker CIiswas failing because it missesgitto checkout the zimscraperlib frommain.I do not want to fix this now, I will rather release zimscraperlib since this PR proves everything is fine in warc2zim to move forward.