-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move scraper to subfolder and initialize new Vue.js project #207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments inline.
Some other points:
- you must mention in your issue that:
- you've started the move to "on-the-fly" items addition to the ZIM (I've just opened Use scraperlib & pylibzim properly - add items to the ZIM "on the fly" #209 which is about it, the move is not yet finished since you have to fix all commented code)
- from this point, the scraper is intentionally quite broken in the sense that it does not create a usable ZIM anymore since we had to comment out significant code portions to move to the new ZIM ui and creator
- add a disclaimer at the beginning of README.md explaining that for now the scraper is undergoing significant rework for 3.0 release and the
main
branch is not very stable ;v2
branch is available (I just created it) should an important patch be pushed before v3 release - do we really need to keep the
zimui/README.md
, it does not provide much value from my PoV ?
We should also open new issues to not forget that we have to (no need to do it in current PR, can be tackled afterwards):
- add a
CONTRIBUTING.md
at the root of the project explaining how to develop thezimui
, just like we have at https://github.com/openzim/kolibri/blob/new_ui/CONTRIBUTING.md - fix code coverage upload for Python part ; looking at the CI it looks like it fails to find the coverage report, it is probably broken as well in kolibri ; since we have almost zero test anyway, it is not an urgent problem to solve ^^
Updated the README.md with a disclaimer and removed the README in the zimui folder in 7431881 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Changes:
scraper
subfolderzimui
subfolder; it is rendered with Vite to produce a static website.--zimui-dist
has been added to specify the folder where zimui has been builtCreator
instead ofmake_zim_file
Disclaimer:
From this point, the scraper is intentionally quite broken in the sense that it does not create a usable ZIM anymore since we had to comment out significant code portions to move to the new ZIM UI and Creator.Closes #205